Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros.

third_party/WebKit/public/platform/WebCommon.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 55 matching lines @@
         #define BLINK_COMMON_EXPORT __attribute__((visibility("default")))
     #endif
 #else // defined(COMPONENT_BUILD)
     #define BLINK_EXPORT
     #define BLINK_PLATFORM_EXPORT
     #define BLINK_COMMON_EXPORT
 #endif
 
 
 // -----------------------------------------------------------------------------
+// Assertions
+
+#include "base/logging.h"

[tkent, 2016/04/03 22:59:06]

WebCommon.h shouldn't include base/logging.h.  Each of files using DCHECK should
include base/logging.h.

[haraken, 2016/04/03 23:53:46]

This is a tricky part since core/, modules/ and web/ are not allowed to include
base/. But we want to allow core/, modules/ and web/ to use macros defined in
Chromium.

As far as I understand, our plan is:

- For normal classes, define a thin wrapper in wtf/ or platform/ to be used by
core/, modules/ and web/
- For macros, allow core/, modules/ and web/ to use them directly.
- core/, modules/ and web/ cannot include base/ anyway.

To meet the requirements, maybe do we need to introduce wtf/macros.h which
includes base/logging.h etc? Or would there be any better way?

[kotenkov, 2016/04/04 07:46:34]

There already exists such a file: wtf/Assertions.h. The problem is that we
cannot include wtf from outside of BLINK_IMPLEMENTATION.

[tkent, 2016/04/04 09:03:17]

Right.  So, I think using base/logging.h directly in public/platform is a
reasonable exception.

+
+// -----------------------------------------------------------------------------
 // Basic types
 
 #include <stddef.h> // For size_t
 #include <stdint.h> // For int32_t
 
 namespace blink {
 
 // UTF-32 character type
 typedef int32_t WebUChar32;
 
 // UTF-16 character type
 #if defined(WIN32)
 typedef wchar_t WebUChar;
 #else
 typedef unsigned short WebUChar;
 #endif
 
 // Latin-1 character type
 typedef unsigned char WebLChar;
 
-// -----------------------------------------------------------------------------
-// Assertions
-
-BLINK_COMMON_EXPORT void failedAssertion(const char* file, int line, const char* function, const char* assertion);

[tkent, 2016/04/03 22:59:06]

We should remove failedAssertion() implementation in
platform/exported/WebCommon.cpp.

-
 } // namespace blink
 
-// Ideally, only use inside the public directory but outside of INSIDE_BLINK blocks.  (Otherwise use WTF's ASSERT.)
-#if defined(NDEBUG)
-#define BLINK_ASSERT(assertion) ((void)0)
-#else
-#define BLINK_ASSERT(assertion) do { \
-    if (!(assertion)) \
-        failedAssertion(__FILE__, __LINE__, __FUNCTION__, #assertion); \
-} while (0)
 #endif
-
-#define BLINK_ASSERT_NOT_REACHED() BLINK_ASSERT(0)
-
-#endif