Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 1851243002: [Sync] Eliminate verifier profile from sync_integration_tests (Closed)

Created:
4 years, 8 months ago by shadi
Modified:
4 years, 8 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Eliminate verifier profile from sync_integration_tests This is one of a series of changes to get rid of verifier profile in two client sync integration tests. This CL affects apps and app_list two client tests only. BUG=598802 Committed: https://crrev.com/302d0ea71f818208bb2cded1a7a61f77ca7d083c Cr-Commit-Position: refs/heads/master@{#385006}

Patch Set 1 #

Patch Set 2 : do not remove AwaitQuiescence() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -314 lines) Patch
M chrome/browser/sync/test/integration/apps_helper.h View 2 chunks +12 lines, -5 lines 0 comments Download
M chrome/browser/sync/test/integration/apps_helper.cc View 4 chunks +23 lines, -11 lines 0 comments Download
M chrome/browser/sync/test/integration/autofill_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/autofill_helper.cc View 6 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/sync/test/integration/extensions_helper.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/performance/autofill_sync_perf_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_app_list_sync_test.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_apps_sync_test.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_app_list_helper.h View 3 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_app_list_helper.cc View 3 chunks +31 lines, -52 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_app_list_sync_test.cc View 1 22 chunks +71 lines, -135 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_apps_sync_test.cc View 18 chunks +7 lines, -40 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_autofill_sync_test.cc View 14 chunks +37 lines, -37 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
shadi
Hi zea@, this is the same CL as https://codereview.chromium.org/1834323004 minus AwaitQuiescence() changes. Context, in previous ...
4 years, 8 months ago (2016-04-04 17:30:14 UTC) #2
Nicolas Zea
lgtm
4 years, 8 months ago (2016-04-04 20:15:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851243002/20001
4 years, 8 months ago (2016-04-04 20:30:04 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-04 21:14:56 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 21:17:10 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/302d0ea71f818208bb2cded1a7a61f77ca7d083c
Cr-Commit-Position: refs/heads/master@{#385006}

Powered by Google App Engine
This is Rietveld 408576698