[Sync] Eliminate verifier profile from sync_integration_tests

[Sync] Eliminate verifier profile from sync_integration_tests

This is one of a series of changes to get rid of verifier profile in two client
sync integration tests.

This CL affects apps and app_list two client tests only.

BUG=598802
Committed: https://crrev.com/d2ab74fab3dee525cadb6838bb65eb6b3580b4d4
Cr-Commit-Position: refs/heads/master@{#384462}

[shadi, 2016-03-29 21:09:57]

Patchset #1 (id:1) has been deleted

[shadi, 2016-03-30 20:23:47]

shadi@chromium.org changed reviewers:
+ zea@chromium.org

[shadi, 2016-03-30 20:23:48]

PTAL.

FYI, the tests passed the try bots on linux and windows but failed couple of
tests in Mac. I am debugging if this is a flake or a real Mac issue but wanted
the code review to start.

[shadi, 2016-03-30 20:24:43]

On 2016/03/30 20:23:48, shadi wrote:
> PTAL.
> 
> FYI, the tests passed the try bots on linux and windows but failed couple of
> tests in Mac. I am debugging if this is a flake or a real Mac issue but wanted
> the code review to start.

PS: The linux try bot is red but it is not a sync_integreation_tests failure.

[Nicolas Zea, 2016-03-31 19:01:22]

https://codereview.chromium.org/1834323004/diff/40001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/apps_helper.cc (right):

https://codereview.chromium.org/1834323004/diff/40001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/apps_helper.cc:42: bool
HasSameAppsAsVerifier(int index) {
can this be deleted?

https://codereview.chromium.org/1834323004/diff/40001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/apps_helper.cc:49: Profile* profile0 = *it;
nit: have this be part of for loop? I think you can just do profile0 =
profiles.begin().next()?

nit: you can also use auto instead of having to declare it as an iterator, here
and below (see https://google.github.io/styleguide/cppguide.html#auto)

https://codereview.chromium.org/1834323004/diff/40001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/sync_app_list_helper.cc (right):

https://codereview.chromium.org/1834323004/diff/40001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/sync_app_list_helper.cc:99: Profile*
profile1 = *it;
same comment about moving into for loop

[shadi, 2016-03-31 22:46:48]

PTAL

https://codereview.chromium.org/1834323004/diff/40001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/apps_helper.cc (right):

https://codereview.chromium.org/1834323004/diff/40001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/apps_helper.cc:42: bool
HasSameAppsAsVerifier(int index) {
On 2016/03/31 19:01:21, Nicolas Zea wrote:
> can this be deleted?

Done.

https://codereview.chromium.org/1834323004/diff/40001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/apps_helper.cc:49: Profile* profile0 = *it;
On 2016/03/31 19:01:21, Nicolas Zea wrote:
> nit: have this be part of for loop? I think you can just do profile0 =
> profiles.begin().next()?
> 
> nit: you can also use auto instead of having to declare it as an iterator,
here
> and below (see https://google.github.io/styleguide/cppguide.html#auto)

Done.

https://codereview.chromium.org/1834323004/diff/40001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/sync_app_list_helper.cc (right):

https://codereview.chromium.org/1834323004/diff/40001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/sync_app_list_helper.cc:99: Profile*
profile1 = *it;
On 2016/03/31 19:01:22, Nicolas Zea wrote:
> same comment about moving into for loop

Done.

[Nicolas Zea, 2016-04-01 00:40:17]

lgtm

[shadi, 2016-04-01 00:40:41]

The CQ bit was checked by shadi@chromium.org

[commit-bot: I haz the power, 2016-04-01 00:41:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834323004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834323004/60001

[commit-bot: I haz the power, 2016-04-01 01:17:16]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-04-01 01:18:30]

Description was changed from

==========
[Sync] Eliminate verifier profile from sync_integration_tests

This is one of a series of changes to get rid of verifier profile in two client
sync integration tests.

This CL affects apps and app_list two client tests only.

BUG=598802
==========

to

==========
[Sync] Eliminate verifier profile from sync_integration_tests

This is one of a series of changes to get rid of verifier profile in two client
sync integration tests.

This CL affects apps and app_list two client tests only.

BUG=598802

Committed: https://crrev.com/d2ab74fab3dee525cadb6838bb65eb6b3580b4d4
Cr-Commit-Position: refs/heads/master@{#384462}
==========

[commit-bot: I haz the power, 2016-04-01 01:18:31]

Patchset 3 (id:??) landed as
https://crrev.com/d2ab74fab3dee525cadb6838bb65eb6b3580b4d4
Cr-Commit-Position: refs/heads/master@{#384462}

[Łukasz Anforowicz, 2016-04-01 18:20:49]

A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/1850253002/ by lukasza@chromium.org.

The reason for reverting is: This CL has resulted in test flakiness - please see
https://crbug.com/599787.