Reland of [tracing] Adding task information to heap profiler

Reland of [tracing] Adding task information to heap profiler (patchset #1 id:1 of https://codereview.chromium.org/1846333002/ )

Reason for revert:
Fixing the flakiness in trace_test by removing the event from
sequenced_worker_pool.cc. 2 trace events together somehow causes multiple
calls to UpdateDuration. I couldn't reproduce yet.
Also because 2 trace events there is not necessary, I will figure out a
way to add WorkerPool task information in next CL.

Original issue's description:
> Revert of [tracing] Adding task information to heap profiler (patchset #18 id:630001 of https://codereview.chromium.org/1784133002/ )
>
> Reason for revert:
> Caused flakiness of trace_test; see Issue 599794.
>
> Original issue's description:
> > [tracing] Adding task information to heap profiler
> >
> > This CL adds more information to the malloc heap profiler added in
> > crrev.com/1675183006. The heap profiler only shows trace events and all
> > the tasks show up as "MessageLoop::Runtask".
> >
> > This CL does:
> >  - Moves TRACE_TASK_EXECUTION macro from task_annotator to
> >    trace_event.h.
> >  - Adds extra scoped trace event to track the task context in heap
> >    profiler.
> >  - The folder where the task was posted from is used to categorize
> >    allocations.
> >  - Uses the type_name for context temporarily till we define a new
> >    context dimension for allocations.
> >
> > BUG=594803
> >
> > Committed: https://crrev.com/533c402f8b21e503ebcaf3f0de427f41076b4de1
> > Cr-Commit-Position: refs/heads/master@{#384521}
>
> TBR=jochen@chromium.org,dskiba@google.com,oysteine@chromium.org,petrcermak@chromium.org,primiano@chromium.org,skyostil@chromium.org,thakis@chromium.org,ssid@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=594803
>
> Committed: https://crrev.com/7a3a6793b5a471280e64842060d565e6f52e939f
> Cr-Commit-Position: refs/heads/master@{#384695}

TBR=jochen@chromium.org,dskiba@google.com,oysteine@chromium.org,petrcermak@chromium.org,primiano@chromium.org,skyostil@chromium.org,thakis@chromium.org,kbr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
BUG=594803
Committed: https://crrev.com/092c384b364d376d8ef4971cf43a5b11aa2884cf
Cr-Commit-Position: refs/heads/master@{#384795}

[ssid, 2016-04-01 22:33:06]

Created Reland of [tracing] Adding task information to heap profiler

[ssid, 2016-04-01 22:36:50]

Description was changed from

==========
Reland of [tracing] Adding task information to heap profiler (patchset #1 id:1
of https://codereview.chromium.org/1846333002/ )

Reason for revert:
Fixing the flakiness in trace_test by removing the event from
sequenced_worker_pool.cc.
Also because there are 2 trace events there, I will figure out a way to add
WorkerPool task information in next CL.

Original issue's description:
> Revert of [tracing] Adding task information to heap profiler (patchset #18
id:630001 of https://codereview.chromium.org/1784133002/ )
> 
> Reason for revert:
> Caused flakiness of trace_test; see Issue 599794.
> 
> Original issue's description:
> > [tracing] Adding task information to heap profiler
> >
> > This CL adds more information to the malloc heap profiler added in
> > crrev.com/1675183006. The heap profiler only shows trace events and all
> > the tasks show up as "MessageLoop::Runtask".
> >
> > This CL does:
> >  - Moves TRACE_TASK_EXECUTION macro from task_annotator to
> >    trace_event.h.
> >  - Adds extra scoped trace event to track the task context in heap
> >    profiler.
> >  - The folder where the task was posted from is used to categorize
> >    allocations.
> >  - Uses the type_name for context temporarily till we define a new
> >    context dimension for allocations.
> >
> > BUG=594803
> >
> > Committed: https://crrev.com/533c402f8b21e503ebcaf3f0de427f41076b4de1
> > Cr-Commit-Position: refs/heads/master@{#384521}
> 
>
TBR=jochen@chromium.org,dskiba@google.com,oysteine@chromium.org,petrcermak@ch...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=594803
> 
> Committed: https://crrev.com/7a3a6793b5a471280e64842060d565e6f52e939f
> Cr-Commit-Position: refs/heads/master@{#384695}

TBR=jochen@chromium.org,dskiba@google.com,oysteine@chromium.org,petrcermak@ch...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=594803
==========

to

==========
Reland of [tracing] Adding task information to heap profiler (patchset #1 id:1
of https://codereview.chromium.org/1846333002/ )

Reason for revert:
Fixing the flakiness in trace_test by removing the event from
sequenced_worker_pool.cc. 2 trace events together somehow causes multiple
calls to UpdateDuration. I couldn't reproduce yet.
Also because 2 trace events there is not necessary, I will figure out a
way to add WorkerPool task information in next CL.

Original issue's description:
> Revert of [tracing] Adding task information to heap profiler (patchset #18
id:630001 of https://codereview.chromium.org/1784133002/ )
> 
> Reason for revert:
> Caused flakiness of trace_test; see Issue 599794.
> 
> Original issue's description:
> > [tracing] Adding task information to heap profiler
> >
> > This CL adds more information to the malloc heap profiler added in
> > crrev.com/1675183006. The heap profiler only shows trace events and all
> > the tasks show up as "MessageLoop::Runtask".
> >
> > This CL does:
> >  - Moves TRACE_TASK_EXECUTION macro from task_annotator to
> >    trace_event.h.
> >  - Adds extra scoped trace event to track the task context in heap
> >    profiler.
> >  - The folder where the task was posted from is used to categorize
> >    allocations.
> >  - Uses the type_name for context temporarily till we define a new
> >    context dimension for allocations.
> >
> > BUG=594803
> >
> > Committed: https://crrev.com/533c402f8b21e503ebcaf3f0de427f41076b4de1
> > Cr-Commit-Position: refs/heads/master@{#384521}
> 
>
TBR=jochen@chromium.org,dskiba@google.com,oysteine@chromium.org,petrcermak@ch...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=594803
> 
> Committed: https://crrev.com/7a3a6793b5a471280e64842060d565e6f52e939f
> Cr-Commit-Position: refs/heads/master@{#384695}

TBR=jochen@chromium.org,dskiba@google.com,oysteine@chromium.org,petrcermak@ch...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=594803
==========

[ssid, 2016-04-02 00:08:07]

Description was changed from

==========
Reland of [tracing] Adding task information to heap profiler (patchset #1 id:1
of https://codereview.chromium.org/1846333002/ )

Reason for revert:
Fixing the flakiness in trace_test by removing the event from
sequenced_worker_pool.cc. 2 trace events together somehow causes multiple
calls to UpdateDuration. I couldn't reproduce yet.
Also because 2 trace events there is not necessary, I will figure out a
way to add WorkerPool task information in next CL.

Original issue's description:
> Revert of [tracing] Adding task information to heap profiler (patchset #18
id:630001 of https://codereview.chromium.org/1784133002/ )
> 
> Reason for revert:
> Caused flakiness of trace_test; see Issue 599794.
> 
> Original issue's description:
> > [tracing] Adding task information to heap profiler
> >
> > This CL adds more information to the malloc heap profiler added in
> > crrev.com/1675183006. The heap profiler only shows trace events and all
> > the tasks show up as "MessageLoop::Runtask".
> >
> > This CL does:
> >  - Moves TRACE_TASK_EXECUTION macro from task_annotator to
> >    trace_event.h.
> >  - Adds extra scoped trace event to track the task context in heap
> >    profiler.
> >  - The folder where the task was posted from is used to categorize
> >    allocations.
> >  - Uses the type_name for context temporarily till we define a new
> >    context dimension for allocations.
> >
> > BUG=594803
> >
> > Committed: https://crrev.com/533c402f8b21e503ebcaf3f0de427f41076b4de1
> > Cr-Commit-Position: refs/heads/master@{#384521}
> 
>
TBR=jochen@chromium.org,dskiba@google.com,oysteine@chromium.org,petrcermak@ch...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=594803
> 
> Committed: https://crrev.com/7a3a6793b5a471280e64842060d565e6f52e939f
> Cr-Commit-Position: refs/heads/master@{#384695}

TBR=jochen@chromium.org,dskiba@google.com,oysteine@chromium.org,petrcermak@ch...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=594803
==========

to

==========
Reland of [tracing] Adding task information to heap profiler (patchset #1 id:1
of https://codereview.chromium.org/1846333002/ )

Reason for revert:
Fixing the flakiness in trace_test by removing the event from
sequenced_worker_pool.cc. 2 trace events together somehow causes multiple
calls to UpdateDuration. I couldn't reproduce yet.
Also because 2 trace events there is not necessary, I will figure out a
way to add WorkerPool task information in next CL.

Original issue's description:
> Revert of [tracing] Adding task information to heap profiler (patchset #18
id:630001 of https://codereview.chromium.org/1784133002/ )
> 
> Reason for revert:
> Caused flakiness of trace_test; see Issue 599794.
> 
> Original issue's description:
> > [tracing] Adding task information to heap profiler
> >
> > This CL adds more information to the malloc heap profiler added in
> > crrev.com/1675183006. The heap profiler only shows trace events and all
> > the tasks show up as "MessageLoop::Runtask".
> >
> > This CL does:
> >  - Moves TRACE_TASK_EXECUTION macro from task_annotator to
> >    trace_event.h.
> >  - Adds extra scoped trace event to track the task context in heap
> >    profiler.
> >  - The folder where the task was posted from is used to categorize
> >    allocations.
> >  - Uses the type_name for context temporarily till we define a new
> >    context dimension for allocations.
> >
> > BUG=594803
> >
> > Committed: https://crrev.com/533c402f8b21e503ebcaf3f0de427f41076b4de1
> > Cr-Commit-Position: refs/heads/master@{#384521}
> 
>
TBR=jochen@chromium.org,dskiba@google.com,oysteine@chromium.org,petrcermak@ch...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=594803
> 
> Committed: https://crrev.com/7a3a6793b5a471280e64842060d565e6f52e939f
> Cr-Commit-Position: refs/heads/master@{#384695}

TBR=jochen@chromium.org,dskiba@google.com,oysteine@chromium.org,petrcermak@ch...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
BUG=594803
==========

[ssid, 2016-04-02 00:08:53]

The CQ bit was checked by ssid@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-02 00:09:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851233002/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851233002/280001

[commit-bot: I haz the power, 2016-04-02 03:26:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-02 03:26:36]

Dry run: This issue passed the CQ dry run.

[ssid, 2016-04-02 04:21:33]

The CQ bit was checked by ssid@chromium.org

[commit-bot: I haz the power, 2016-04-02 04:21:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851233002/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851233002/280001

[commit-bot: I haz the power, 2016-04-02 04:22:16]

Description was changed from

==========
Reland of [tracing] Adding task information to heap profiler (patchset #1 id:1
of https://codereview.chromium.org/1846333002/ )

Reason for revert:
Fixing the flakiness in trace_test by removing the event from
sequenced_worker_pool.cc. 2 trace events together somehow causes multiple
calls to UpdateDuration. I couldn't reproduce yet.
Also because 2 trace events there is not necessary, I will figure out a
way to add WorkerPool task information in next CL.

Original issue's description:
> Revert of [tracing] Adding task information to heap profiler (patchset #18
id:630001 of https://codereview.chromium.org/1784133002/ )
> 
> Reason for revert:
> Caused flakiness of trace_test; see Issue 599794.
> 
> Original issue's description:
> > [tracing] Adding task information to heap profiler
> >
> > This CL adds more information to the malloc heap profiler added in
> > crrev.com/1675183006. The heap profiler only shows trace events and all
> > the tasks show up as "MessageLoop::Runtask".
> >
> > This CL does:
> >  - Moves TRACE_TASK_EXECUTION macro from task_annotator to
> >    trace_event.h.
> >  - Adds extra scoped trace event to track the task context in heap
> >    profiler.
> >  - The folder where the task was posted from is used to categorize
> >    allocations.
> >  - Uses the type_name for context temporarily till we define a new
> >    context dimension for allocations.
> >
> > BUG=594803
> >
> > Committed: https://crrev.com/533c402f8b21e503ebcaf3f0de427f41076b4de1
> > Cr-Commit-Position: refs/heads/master@{#384521}
> 
>
TBR=jochen@chromium.org,dskiba@google.com,oysteine@chromium.org,petrcermak@ch...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=594803
> 
> Committed: https://crrev.com/7a3a6793b5a471280e64842060d565e6f52e939f
> Cr-Commit-Position: refs/heads/master@{#384695}

TBR=jochen@chromium.org,dskiba@google.com,oysteine@chromium.org,petrcermak@ch...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
BUG=594803
==========

to

==========
Reland of [tracing] Adding task information to heap profiler (patchset #1 id:1
of https://codereview.chromium.org/1846333002/ )

Reason for revert:
Fixing the flakiness in trace_test by removing the event from
sequenced_worker_pool.cc. 2 trace events together somehow causes multiple
calls to UpdateDuration. I couldn't reproduce yet.
Also because 2 trace events there is not necessary, I will figure out a
way to add WorkerPool task information in next CL.

Original issue's description:
> Revert of [tracing] Adding task information to heap profiler (patchset #18
id:630001 of https://codereview.chromium.org/1784133002/ )
> 
> Reason for revert:
> Caused flakiness of trace_test; see Issue 599794.
> 
> Original issue's description:
> > [tracing] Adding task information to heap profiler
> >
> > This CL adds more information to the malloc heap profiler added in
> > crrev.com/1675183006. The heap profiler only shows trace events and all
> > the tasks show up as "MessageLoop::Runtask".
> >
> > This CL does:
> >  - Moves TRACE_TASK_EXECUTION macro from task_annotator to
> >    trace_event.h.
> >  - Adds extra scoped trace event to track the task context in heap
> >    profiler.
> >  - The folder where the task was posted from is used to categorize
> >    allocations.
> >  - Uses the type_name for context temporarily till we define a new
> >    context dimension for allocations.
> >
> > BUG=594803
> >
> > Committed: https://crrev.com/533c402f8b21e503ebcaf3f0de427f41076b4de1
> > Cr-Commit-Position: refs/heads/master@{#384521}
> 
>
TBR=jochen@chromium.org,dskiba@google.com,oysteine@chromium.org,petrcermak@ch...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=594803
> 
> Committed: https://crrev.com/7a3a6793b5a471280e64842060d565e6f52e939f
> Cr-Commit-Position: refs/heads/master@{#384695}

TBR=jochen@chromium.org,dskiba@google.com,oysteine@chromium.org,petrcermak@ch...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
BUG=594803
==========

[commit-bot: I haz the power, 2016-04-02 04:22:18]

Committed patchset #2 (id:280001)

[commit-bot: I haz the power, 2016-04-02 04:23:25]

Description was changed from

==========
Reland of [tracing] Adding task information to heap profiler (patchset #1 id:1
of https://codereview.chromium.org/1846333002/ )

Reason for revert:
Fixing the flakiness in trace_test by removing the event from
sequenced_worker_pool.cc. 2 trace events together somehow causes multiple
calls to UpdateDuration. I couldn't reproduce yet.
Also because 2 trace events there is not necessary, I will figure out a
way to add WorkerPool task information in next CL.

Original issue's description:
> Revert of [tracing] Adding task information to heap profiler (patchset #18
id:630001 of https://codereview.chromium.org/1784133002/ )
> 
> Reason for revert:
> Caused flakiness of trace_test; see Issue 599794.
> 
> Original issue's description:
> > [tracing] Adding task information to heap profiler
> >
> > This CL adds more information to the malloc heap profiler added in
> > crrev.com/1675183006. The heap profiler only shows trace events and all
> > the tasks show up as "MessageLoop::Runtask".
> >
> > This CL does:
> >  - Moves TRACE_TASK_EXECUTION macro from task_annotator to
> >    trace_event.h.
> >  - Adds extra scoped trace event to track the task context in heap
> >    profiler.
> >  - The folder where the task was posted from is used to categorize
> >    allocations.
> >  - Uses the type_name for context temporarily till we define a new
> >    context dimension for allocations.
> >
> > BUG=594803
> >
> > Committed: https://crrev.com/533c402f8b21e503ebcaf3f0de427f41076b4de1
> > Cr-Commit-Position: refs/heads/master@{#384521}
> 
>
TBR=jochen@chromium.org,dskiba@google.com,oysteine@chromium.org,petrcermak@ch...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=594803
> 
> Committed: https://crrev.com/7a3a6793b5a471280e64842060d565e6f52e939f
> Cr-Commit-Position: refs/heads/master@{#384695}

TBR=jochen@chromium.org,dskiba@google.com,oysteine@chromium.org,petrcermak@ch...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
BUG=594803
==========

to

==========
Reland of [tracing] Adding task information to heap profiler (patchset #1 id:1
of https://codereview.chromium.org/1846333002/ )

Reason for revert:
Fixing the flakiness in trace_test by removing the event from
sequenced_worker_pool.cc. 2 trace events together somehow causes multiple
calls to UpdateDuration. I couldn't reproduce yet.
Also because 2 trace events there is not necessary, I will figure out a
way to add WorkerPool task information in next CL.

Original issue's description:
> Revert of [tracing] Adding task information to heap profiler (patchset #18
id:630001 of https://codereview.chromium.org/1784133002/ )
>
> Reason for revert:
> Caused flakiness of trace_test; see Issue 599794.
>
> Original issue's description:
> > [tracing] Adding task information to heap profiler
> >
> > This CL adds more information to the malloc heap profiler added in
> > crrev.com/1675183006. The heap profiler only shows trace events and all
> > the tasks show up as "MessageLoop::Runtask".
> >
> > This CL does:
> >  - Moves TRACE_TASK_EXECUTION macro from task_annotator to
> >    trace_event.h.
> >  - Adds extra scoped trace event to track the task context in heap
> >    profiler.
> >  - The folder where the task was posted from is used to categorize
> >    allocations.
> >  - Uses the type_name for context temporarily till we define a new
> >    context dimension for allocations.
> >
> > BUG=594803
> >
> > Committed: https://crrev.com/533c402f8b21e503ebcaf3f0de427f41076b4de1
> > Cr-Commit-Position: refs/heads/master@{#384521}
>
>
TBR=jochen@chromium.org,dskiba@google.com,oysteine@chromium.org,petrcermak@ch...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=594803
>
> Committed: https://crrev.com/7a3a6793b5a471280e64842060d565e6f52e939f
> Cr-Commit-Position: refs/heads/master@{#384695}

TBR=jochen@chromium.org,dskiba@google.com,oysteine@chromium.org,petrcermak@ch...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
BUG=594803

Committed: https://crrev.com/092c384b364d376d8ef4971cf43a5b11aa2884cf
Cr-Commit-Position: refs/heads/master@{#384795}
==========

[commit-bot: I haz the power, 2016-04-02 04:23:26]

Patchset 2 (id:??) landed as
https://crrev.com/092c384b364d376d8ef4971cf43a5b11aa2884cf
Cr-Commit-Position: refs/heads/master@{#384795}

[Primiano Tucci (use gerrit), 2016-04-04 10:25:34]

The diff between PS1 and PS2 seems null. What is the difference w.r.t. the
original CL? Very hard to tell from here. :-/

[Primiano Tucci (use gerrit), 2016-04-04 11:17:15]

On 2016/04/04 10:25:34, Primiano Tucci wrote:
> The diff between PS1 and PS2 seems null. What is the difference w.r.t. the
> original CL? Very hard to tell from here. :-/

Ah never mind, figured out the 	base/threading/sequenced_worker_pool.cc change.
The fact that updateduration is called twice, as per crbug.com/599794#c9, smells
very bad though. Can you please investigate and figure out what's going on?