Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1846333002: Revert of [tracing] Adding task information to heap profiler (Closed)

Created:
4 years, 8 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 8 months ago
CC:
chirantan+watch_chromium.org, chromium-reviews, sadrul, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [tracing] Adding task information to heap profiler (patchset #18 id:630001 of https://codereview.chromium.org/1784133002/ ) Reason for revert: Caused flakiness of trace_test; see Issue 599794. Original issue's description: > [tracing] Adding task information to heap profiler > > This CL adds more information to the malloc heap profiler added in > crrev.com/1675183006. The heap profiler only shows trace events and all > the tasks show up as "MessageLoop::Runtask". > > This CL does: > - Moves TRACE_TASK_EXECUTION macro from task_annotator to > trace_event.h. > - Adds extra scoped trace event to track the task context in heap > profiler. > - The folder where the task was posted from is used to categorize > allocations. > - Uses the type_name for context temporarily till we define a new > context dimension for allocations. > > BUG=594803 > > Committed: https://crrev.com/533c402f8b21e503ebcaf3f0de427f41076b4de1 > Cr-Commit-Position: refs/heads/master@{#384521} TBR=jochen@chromium.org,dskiba@google.com,oysteine@chromium.org,petrcermak@chromium.org,primiano@chromium.org,skyostil@chromium.org,thakis@chromium.org,ssid@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=594803 Committed: https://crrev.com/7a3a6793b5a471280e64842060d565e6f52e939f Cr-Commit-Position: refs/heads/master@{#384695}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -169 lines) Patch
M base/debug/task_annotator.h View 1 chunk +5 lines, -0 lines 0 comments Download
M base/threading/sequenced_worker_pool.cc View 1 chunk +0 lines, -1 line 0 comments Download
M base/threading/worker_pool_posix.cc View 1 chunk +3 lines, -1 line 0 comments Download
M base/threading/worker_pool_win.cc View 1 chunk +3 lines, -1 line 0 comments Download
M base/trace_event/common/trace_event_common.h View 1 chunk +0 lines, -9 lines 0 comments Download
M base/trace_event/heap_profiler_allocation_context_tracker.h View 2 chunks +0 lines, -9 lines 0 comments Download
M base/trace_event/heap_profiler_allocation_context_tracker.cc View 4 chunks +1 line, -19 lines 0 comments Download
M base/trace_event/heap_profiler_allocation_context_tracker_unittest.cc View 2 chunks +0 lines, -27 lines 0 comments Download
M base/trace_event/heap_profiler_type_name_deduplicator.cc View 2 chunks +1 line, -32 lines 0 comments Download
M base/trace_event/heap_profiler_type_name_deduplicator_unittest.cc View 3 chunks +14 lines, -39 lines 0 comments Download
M base/trace_event/trace_event.h View 3 chunks +0 lines, -30 lines 0 comments Download
M components/scheduler/base/task_queue_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Ken Russell (switch to Gerrit)
Created Revert of [tracing] Adding task information to heap profiler
4 years, 8 months ago (2016-04-01 21:44:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846333002/1
4 years, 8 months ago (2016-04-01 21:45:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 21:45:59 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7a3a6793b5a471280e64842060d565e6f52e939f Cr-Commit-Position: refs/heads/master@{#384695}
4 years, 8 months ago (2016-04-01 21:47:41 UTC) #6
ssid
4 years, 8 months ago (2016-04-01 22:33:06 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1851233002/ by ssid@chromium.org.

The reason for reverting is: Fixing the flakiness in trace_test by removing the
event from sequenced_worker_pool.cc.
Also because there are 2 trace events there, I will figure out a way to add
WorkerPool task information in next CL..

Powered by Google App Engine
This is Rietveld 408576698