Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc

Issue 1851213002: Remove sandbox on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix nacl compile issues Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc
diff --git a/chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc b/chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc
index 6672de3b4a60b7d57fff4317d50be8234a7c4fae..924635a33c133d529d4982c893aa207e3bd6d6aa 100644
--- a/chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc
+++ b/chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc
@@ -21,92 +21,17 @@
#include "chrome/browser/safe_browsing/safe_browsing_service.h"
#include "chrome/common/safe_browsing/binary_feature_extractor.h"
#include "chrome/common/safe_browsing/csd.pb.h"
-#include "chrome_elf/blacklist/blacklist.h"
namespace safe_browsing {
// Retrieves the set of blacklisted modules that are loaded in the process.
// Returns true if successful, false otherwise.
bool GetLoadedBlacklistedModules(std::vector<base::string16>* module_names) {
- DCHECK(module_names);
-
- std::set<ModuleInfo> module_info_set;
- if (!GetLoadedModules(&module_info_set))
- return false;
-
- std::set<ModuleInfo>::const_iterator module_iter(module_info_set.begin());
- for (; module_iter != module_info_set.end(); ++module_iter) {
- base::string16 module_file_name(base::ToLowerASCII(
- base::FilePath(module_iter->name).BaseName().value()));
- if (blacklist::GetBlacklistIndex(module_file_name.c_str()) != -1) {
- module_names->push_back(module_iter->name);
- }
- }
-
return true;
}
void VerifyBlacklistLoadState(scoped_ptr<IncidentReceiver> incident_receiver) {
- std::vector<base::string16> module_names;
- if (GetLoadedBlacklistedModules(&module_names)) {
- PathSanitizer path_sanitizer;
-
- const bool blacklist_intialized = blacklist::IsBlacklistInitialized();
-
- for (const auto& module_name : module_names) {
- scoped_ptr<ClientIncidentReport_IncidentData_BlacklistLoadIncident>
- blacklist_load(
- new ClientIncidentReport_IncidentData_BlacklistLoadIncident());
-
- const base::FilePath module_path(module_name);
-
- // Sanitized path.
- base::FilePath sanitized_path(module_path);
- path_sanitizer.StripHomeDirectory(&sanitized_path);
- blacklist_load->set_path(base::WideToUTF8(sanitized_path.value()));
-
- // Digest.
- scoped_refptr<BinaryFeatureExtractor>
- binary_feature_extractor(new BinaryFeatureExtractor());
- base::TimeTicks start_time = base::TimeTicks::Now();
- binary_feature_extractor->ExtractDigest(module_path,
- blacklist_load->mutable_digest());
- UMA_HISTOGRAM_TIMES("SBIRS.BLAHashTime",
- base::TimeTicks::Now() - start_time);
-
- // Version.
- scoped_ptr<FileVersionInfo> version_info(
- FileVersionInfo::CreateFileVersionInfo(module_path));
- if (version_info) {
- std::wstring file_version = version_info->file_version();
- if (!file_version.empty())
- blacklist_load->set_version(base::WideToUTF8(file_version));
- }
-
- // Initialized state.
- blacklist_load->set_blacklist_initialized(blacklist_intialized);
-
- // Signature.
- start_time = base::TimeTicks::Now();
- binary_feature_extractor->CheckSignature(
- module_path, blacklist_load->mutable_signature());
- UMA_HISTOGRAM_TIMES("SBIRS.BLASignatureTime",
- base::TimeTicks::Now() - start_time);
-
- // Image headers.
- if (!binary_feature_extractor->ExtractImageFeatures(
- module_path,
- BinaryFeatureExtractor::kDefaultOptions,
- blacklist_load->mutable_image_headers(),
- nullptr /* signed_data */)) {
- blacklist_load->clear_image_headers();
- }
-
- // Send the report.
- incident_receiver->AddIncidentForProcess(make_scoped_ptr(
- new BlacklistLoadIncident(std::move(blacklist_load))));
- }
- }
+ // TODO(implement this)
}
} // namespace safe_browsing

Powered by Google App Engine
This is Rietveld 408576698