Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1851163003: Mac h264: Use GLImageIOSurface to bind frames to textures (Closed)

Created:
4 years, 8 months ago by ccameron
Modified:
4 years, 8 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac h264: Use GLImageIOSurface to bind frames to textures A framework for binding IOSurfaces to textures was added after accelerated h264 decode landed. Move the accelerated h264 code over to using this path. This is a slow re-introduction of the previous patch to enable h264 decode to 4:2:0 IOSurfaces, to see where we started causing instability. BUG=594452 Committed: https://crrev.com/aa1cd6f9624e83497223680ac8d3e75da2665bd7 Cr-Commit-Position: refs/heads/master@{#384712}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -25 lines) Patch
M content/common/gpu/media/vt_video_decode_accelerator_mac.cc View 2 chunks +15 lines, -25 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
ccameron
Small patch (that you previously saw in https://codereview.chromium.org/1822173002/). I'm putting money on there being OpenGL ...
4 years, 8 months ago (2016-04-01 21:07:49 UTC) #3
sandersd (OOO until July 31)
lgtm
4 years, 8 months ago (2016-04-01 21:13:45 UTC) #4
sandersd (OOO until July 31)
lgtm lgtm
4 years, 8 months ago (2016-04-01 21:13:46 UTC) #5
ccameron
Thanks!
4 years, 8 months ago (2016-04-01 21:15:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851163003/1
4 years, 8 months ago (2016-04-01 21:16:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 22:38:31 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 22:40:59 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa1cd6f9624e83497223680ac8d3e75da2665bd7
Cr-Commit-Position: refs/heads/master@{#384712}

Powered by Google App Engine
This is Rietveld 408576698