Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1848403003: Mac h264: Add a flag to specify GLImage status in hardware decode (Closed)

Created:
4 years, 8 months ago by ccameron
Modified:
4 years, 8 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac h264: Add a flag to specify GLImage status in hardware decode This has no functional effect, but will be needed when we decode to 4:2:0 because that format will not be bound, but rather will require an on-demand copy in order to be used by OpenGL. This is a slow re-introduction of the previous patch to enable h264 decode to 4:2:0 IOSurfaces, to see where we started causing instability. BUG=594452 Committed: https://crrev.com/3fc11d2ecd9f6c928bc3268043f8eb14a2185f4b Cr-Commit-Position: refs/heads/master@{#385067}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -26 lines) Patch
M content/common/gpu/media/gpu_video_decode_accelerator.h View 1 chunk +5 lines, -2 lines 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M content/common/gpu/media/vaapi_video_decode_accelerator.h View 3 chunks +4 lines, -6 lines 0 comments Download
M content/common/gpu/media/vaapi_video_decode_accelerator.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/common/gpu/media/vt_video_decode_accelerator_mac.h View 2 chunks +4 lines, -6 lines 0 comments Download
M content/common/gpu/media/vt_video_decode_accelerator_mac.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M media/video/video_decode_accelerator.h View 2 chunks +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
ccameron
Second part of the re-introduction of the 4:2:0 patch. The first part didn't affect crash ...
4 years, 8 months ago (2016-04-03 04:09:39 UTC) #3
sandersd (OOO until July 31)
lgtm
4 years, 8 months ago (2016-04-04 18:30:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848403003/1
4 years, 8 months ago (2016-04-04 19:04:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/205093)
4 years, 8 months ago (2016-04-04 21:19:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848403003/1
4 years, 8 months ago (2016-04-04 22:57:57 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 00:57:02 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 00:58:08 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3fc11d2ecd9f6c928bc3268043f8eb14a2185f4b
Cr-Commit-Position: refs/heads/master@{#385067}

Powered by Google App Engine
This is Rietveld 408576698