Keep two empty lines between declarations for cpp files

Keep two empty lines between declarations for cpp files

R=yangguo@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=15510

[haitao.feng, 2013-07-04 09:09:47]

Hi Jakob,

Here are the changes we have discussed. I looked over the .cc files and it seems
that they all need two empty lines. If you do not like the changes in
presubmit.py, feel free to drop them.

Thanks
-Haitao

[Yang, 2013-07-04 16:33:00]

Drive-by comment.

https://codereview.chromium.org/18509003/diff/1/tools/presubmit.py
File tools/presubmit.py (right):

https://codereview.chromium.org/18509003/diff/1/tools/presubmit.py#newcode385
tools/presubmit.py:385: "in lines {1}.".format(name, linenumbers)
I think for consistency we could use

"%s ... %s ..." % (name, linenumbers)

for string formatting.

[haitao.feng, 2013-07-05 05:16:37]

https://codereview.chromium.org/18509003/diff/1/tools/presubmit.py
File tools/presubmit.py (right):

https://codereview.chromium.org/18509003/diff/1/tools/presubmit.py#newcode385
tools/presubmit.py:385: "in lines {1}.".format(name, linenumbers)
On 2013/07/04 16:33:00, Yang wrote:
> I think for consistency we could use
> 
> "%s ... %s ..." % (name, linenumbers)
> 
> for string formatting.

Done.

[Yang, 2013-07-05 08:54:22]

On 2013/07/05 05:16:37, haitao.feng wrote:
> https://codereview.chromium.org/18509003/diff/1/tools/presubmit.py
> File tools/presubmit.py (right):
> 
> https://codereview.chromium.org/18509003/diff/1/tools/presubmit.py#newcode385
> tools/presubmit.py:385: "in lines {1}.".format(name, linenumbers)
> On 2013/07/04 16:33:00, Yang wrote:
> > I think for consistency we could use
> > 
> > "%s ... %s ..." % (name, linenumbers)
> > 
> > for string formatting.
> 
> Done.

I ran the presubmit test, and got 

./src/hydrogen.cc does not have two empty lines between declarations in lines
2056, 8611, 9523.
./test/cctest/test-api.cc does not have two empty lines between declarations in
lines 103, 109, 861, 865, 1078, 1694, 1756, 1773, 1793, 1812, 1829, 1846, 1865,
1884, 1908, 1932, 1949, 1966, 2405, 2755, 4387, 4609, 4656, 6319, 7454, 10714,
10815, 10870, 10901, 10938, 10975, 11015, 11055, 11079, 11107, 11140, 11176,
11326, 11428, 11471, 11634, 11952, 11958, 11964, 11970, 12584, 13127, 14235,
14276, 16020, 16327, 16336, 16553, 16612, 16851, 16863, 17093, 17097, 17101,
17105, 17495, 17502, 17517, 17535, 17552, 17594, 17610, 17734, 17769, 17797,
17885, 17889, 17893, 17897, 17901, 17905.

LGTM otherwise.

[haitao.feng, 2013-07-05 09:39:45]

Hi Yang,

Thanks for trying this. It is weird that those two files are not uploaded. I
have sent you two patches (1st for the PRESUBMIT.py and tools/presubmit.py, and
2nd patch could repair this issue automatically). Could you help run the 2nd
script at your site with lastest trunk to get all the other modifications and
revert presubmit.py and then apply 1st patch?  Sorry fo the inconvenience.

Thanks
-Haitao

[Yang, 2013-07-05 09:52:59]

Committed patchset #2 manually as r15510 (presubmit successful).