Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: net/url_request/certificate_report_sender_unittest.cc

Issue 1850853004: Use CertificateReportSender error callback to record HPKP UMA metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: eroman comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/certificate_report_sender.cc ('k') | net/url_request/url_request_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/certificate_report_sender_unittest.cc
diff --git a/net/url_request/certificate_report_sender_unittest.cc b/net/url_request/certificate_report_sender_unittest.cc
index 8cf7a9162e1d34eb783c1d670ec06d901b0de92d..98e7ac8b6c4977bcb03b8b4eb167075d9bc6fa6a 100644
--- a/net/url_request/certificate_report_sender_unittest.cc
+++ b/net/url_request/certificate_report_sender_unittest.cc
@@ -47,10 +47,10 @@ void CheckUploadData(const URLRequest& request,
EXPECT_EQ(1u, expect_reports->erase(upload_data));
}
-// Provides an error callback for report sending. If the callback is
-// called, it sets |called| to true.
-void ErrorCallback(bool* called, URLRequest* request) {
- EXPECT_FALSE(request->status().is_success());
+// Provides an error callback for report sending that sets |called| to
+// true.
+void ErrorCallback(bool* called, const GURL& report_uri, int net_error) {
+ EXPECT_NE(OK, net_error);
*called = true;
}
« no previous file with comments | « net/url_request/certificate_report_sender.cc ('k') | net/url_request/url_request_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698