Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: net/url_request/certificate_report_sender.cc

Issue 1850853004: Use CertificateReportSender error callback to record HPKP UMA metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: eroman comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/certificate_report_sender.h ('k') | net/url_request/certificate_report_sender_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/certificate_report_sender.cc
diff --git a/net/url_request/certificate_report_sender.cc b/net/url_request/certificate_report_sender.cc
index 6091701cbddfd4d4ff0f40f37b9b255570573466..5db245783e7c84c29e542cd8264a02d68a3fd788 100644
--- a/net/url_request/certificate_report_sender.cc
+++ b/net/url_request/certificate_report_sender.cc
@@ -21,12 +21,12 @@ CertificateReportSender::CertificateReportSender(
CookiesPreference cookies_preference)
: CertificateReportSender(request_context,
cookies_preference,
- base::Callback<void(URLRequest*)>()) {}
+ ErrorCallback()) {}
CertificateReportSender::CertificateReportSender(
URLRequestContext* request_context,
CookiesPreference cookies_preference,
- const base::Callback<void(URLRequest*)>& error_callback)
+ const ErrorCallback& error_callback)
: request_context_(request_context),
cookies_preference_(cookies_preference),
error_callback_(error_callback) {}
@@ -60,12 +60,17 @@ void CertificateReportSender::Send(const GURL& report_uri,
raw_url_request->Start();
}
+void CertificateReportSender::SetErrorCallback(
+ const ErrorCallback& error_callback) {
+ error_callback_ = error_callback;
+}
+
void CertificateReportSender::OnResponseStarted(URLRequest* request) {
if (!request->status().is_success()) {
DVLOG(1) << "Failed to send certificate report for "
<< request->url().host();
if (!error_callback_.is_null())
- error_callback_.Run(request);
+ error_callback_.Run(request->url(), request->status().error());
}
CHECK_GT(inflight_requests_.erase(request), 0u);
« no previous file with comments | « net/url_request/certificate_report_sender.h ('k') | net/url_request/certificate_report_sender_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698