third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp - Issue 1850733003: Media: Report informational error messages to HTMLMediaElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp

Issue 1850733003: Media: Report informational error messages to HTMLMediaElement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@use_locking_in_rendermedialog

Patch Set: Fix null MediaLogEvent* dereference in RenderMediaLog::AddEvent() Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp b/third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp

index 661a2cc79207cf3e0bf6a2cb38cf383db972a1c0..61e2b501371780c3dc4932c32ea3943aa943fcc2 100644

--- a/third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp

@@ -40,6 +40,7 @@ public:

double currentTime() const override { return 0.0; };

NetworkState getNetworkState() const override { return NetworkStateEmpty; };

ReadyState getReadyState() const override { return ReadyStateHaveNothing; };

+ WebString getErrorMessage() override { return WebString(); };

bool didLoadingProgress() override { return false; };

bool hasSingleSecurityOrigin() const override { return true; };

bool didPassCORSAccessCheck() const override { return true; };

« media/base/media_log.cc ('K') | « media/blink/webmediaplayer_impl.cc ('k') | third_party/WebKit/public/platform/WebMediaPlayer.h » ('j') | no next file with comments »