Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Unified Diff: media/base/media_log.cc

Issue 1850733003: Media: Report informational error messages to HTMLMediaElement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@use_locking_in_rendermedialog
Patch Set: Fix null MediaLogEvent* dereference in RenderMediaLog::AddEvent() Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/media_log.cc
diff --git a/media/base/media_log.cc b/media/base/media_log.cc
index 8b14cb3b4a72e9777d6e8057ca973af1215590b2..0724fc672a27a5d61dba36a30b65e94117c4b597 100644
--- a/media/base/media_log.cc
+++ b/media/base/media_log.cc
@@ -149,6 +149,9 @@ MediaLog::MediaLog() : id_(g_media_log_count.GetNext()) {}
MediaLog::~MediaLog() {}
void MediaLog::AddEvent(scoped_ptr<MediaLogEvent> event) {}
+std::string MediaLog::GetLastErrorMessage() {
watk 2016/04/04 23:47:25 new line before this?
wolenetz 2016/04/05 00:23:27 Done.
+ return "";
+}
scoped_ptr<MediaLogEvent> MediaLog::CreateEvent(MediaLogEvent::Type type) {
scoped_ptr<MediaLogEvent> event(new MediaLogEvent);

Powered by Google App Engine
This is Rietveld 408576698