Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1850703002: Revert "Adapt and reland old position sticky implementation from https://codereview.chromium.org/34… (Closed)

Created:
4 years, 8 months ago by Sami
Modified:
4 years, 8 months ago
Reviewers:
flackr
CC:
chromium-reviews, dshwang, eae+blinkwatch, apavlov+blink_chromium.org, kinuko+watch, rwlbuis, blink-reviews-css, szager+layoutwatch_chromium.org, dglazkov+blink, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews, kenneth.christiansen, jfernandez, blink-reviews-style_chromium.org, zoltan1, Manuel Rego, blink-reviews-layout_chromium.org, asvitkine+watch_chromium.org, darktears, svillar, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, slimming-paint-reviews_chromium.org, blink-layers+watch_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Adapt and reland old position sticky implementation from https://codereview.chromium.org/346603007" This reverts commit 846f623cb1ef78d90e620c2a7a6557544a86b692 (https://codereview.chromium.org/1308273010/) Reverting because a number of performance tests started crashing. BUG=599505 TBR=flackr@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/e37fce4deefe8c872c4329bdf4233858aab8b9a5 Cr-Commit-Position: refs/heads/master@{#384331}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -4974 lines) Patch
M cc/input/main_thread_scrolling_reason.h View 3 chunks +2 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/inflow-sticky.html View 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/inflow-sticky-expected.html View 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/inline-sticky.html View 1 chunk +0 lines, -91 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/inline-sticky-abspos-child.html View 1 chunk +0 lines, -98 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/inline-sticky-abspos-child-expected.html View 1 chunk +0 lines, -85 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/inline-sticky-anonymous-container.html View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/inline-sticky-anonymous-container-expected.html View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/inline-sticky-expected.html View 1 chunk +0 lines, -76 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/remove-inline-sticky-crash.html View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/remove-inline-sticky-crash-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/remove-sticky-crash.html View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/remove-sticky-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/replaced-sticky.html View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/replaced-sticky-expected.html View 1 chunk +0 lines, -59 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/sticky/sticky-as-positioning-container.html View 1 chunk +26 lines, -68 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/sticky/sticky-as-positioning-container-expected.html View 1 chunk +25 lines, -58 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-both-sides.html View 1 chunk +0 lines, -74 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-both-sides-expected.html View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-bottom-overflow-padding.html View 1 chunk +0 lines, -95 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-bottom-overflow-padding-expected.html View 1 chunk +0 lines, -90 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-container-moved.html View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-container-moved-expected.html View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-display.html View 1 chunk +0 lines, -97 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-display-expected.html View 1 chunk +0 lines, -97 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-flexbox.html View 1 chunk +0 lines, -98 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-flexbox-expected.html View 1 chunk +0 lines, -83 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-grid.html View 1 chunk +0 lines, -97 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-grid-expected.html View 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-horizontally-overconstrained-ltr.html View 1 chunk +0 lines, -83 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-horizontally-overconstrained-ltr-expected.html View 1 chunk +0 lines, -76 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-horizontally-overconstrained-rtl.html View 1 chunk +0 lines, -84 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-horizontally-overconstrained-rtl-expected.html View 1 chunk +0 lines, -77 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-left.html View 1 chunk +0 lines, -77 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-left-expected.html View 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-margin-changed.html View 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-margin-changed-expected.html View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-margins.html View 1 chunk +0 lines, -90 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-margins-expected.html View 1 chunk +0 lines, -76 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-overflow-changed.html View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-overflow-changed-expected.html View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-overflowing.html View 1 chunk +0 lines, -80 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-overflowing-expected.html View 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-scrolls-on-main.html View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-scrolls-on-main-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-side-margins.html View 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-side-margins-expected.html View 1 chunk +0 lines, -53 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/sticky/sticky-stacking-context.html View 1 chunk +20 lines, -53 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/sticky/sticky-stacking-context-expected.html View 1 chunk +19 lines, -45 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-table-col-crash.html View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-table-col-crash-expected.html View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-table-row-top.html View 1 chunk +0 lines, -110 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-table-row-top-expected.html View 1 chunk +0 lines, -68 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-table-thead-top.html View 1 chunk +0 lines, -116 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-table-thead-top-expected.html View 1 chunk +0 lines, -69 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-top.html View 1 chunk +0 lines, -78 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-top-expected.html View 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-top-margins.html View 1 chunk +0 lines, -80 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-top-margins-expected.html View 1 chunk +0 lines, -65 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-top-overflow.html View 1 chunk +0 lines, -88 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-top-overflow-expected.html View 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-top-overflow-scroll-by-fragment.html View 1 chunk +0 lines, -109 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-top-overflow-scroll-by-fragment-expected.html View 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-vertically-overconstrained.html View 1 chunk +0 lines, -83 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-vertically-overconstrained-expected.html View 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-writing-mode-vertical-lr.html View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-writing-mode-vertical-lr-expected.html View 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-writing-mode-vertical-rl.html View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-writing-mode-vertical-rl-expected.html View 1 chunk +0 lines, -60 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.h View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 3 chunks +2 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h View 5 chunks +0 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 6 chunks +6 lines, -179 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGeometryMapStep.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableRow.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp View 3 chunks +0 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp View 3 chunks +1 line, -6 lines 0 comments Download
D third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.h View 1 chunk +0 lines, -85 lines 0 comments Download
D third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.cpp View 1 chunk +0 lines, -56 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.h View 6 chunks +3 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 9 chunks +7 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h View 4 chunks +0 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1850703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1850703002/1
4 years, 8 months ago (2016-03-31 16:24:53 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/43393)
4 years, 8 months ago (2016-03-31 16:34:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1850703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1850703002/1
4 years, 8 months ago (2016-03-31 17:04:21 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/43432)
4 years, 8 months ago (2016-03-31 17:25:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1850703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1850703002/1
4 years, 8 months ago (2016-03-31 17:36:56 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 18:14:59 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 18:16:01 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e37fce4deefe8c872c4329bdf4233858aab8b9a5
Cr-Commit-Position: refs/heads/master@{#384331}

Powered by Google App Engine
This is Rietveld 408576698