Revert "Adapt and reland old position sticky implementation from https://codereview.chromium.org/34…

third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
  *           (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 264 matching lines @@
             bool newStoleBodyBackground = toLayoutBoxModelObject(bodyLayout)->backgroundStolenForBeingBody(style());
             bool oldStoleBodyBackground = oldStyle && toLayoutBoxModelObject(bodyLayout)->backgroundStolenForBeingBody(oldStyle);
             if (newStoleBodyBackground != oldStoleBodyBackground
                 && bodyLayout->style() && bodyLayout->style()->hasBackground()) {
                 bodyLayout->setShouldDoFullPaintInvalidation();
             }
         }
     }
 
     if (FrameView *frameView = view()->frameView()) {
-        bool newStyleIsViewportConstained = style()->position() == FixedPosition;
-        bool oldStyleIsViewportConstrained = oldStyle && oldStyle->position() == FixedPosition;
-        bool newStyleIsSticky = style()->position() == StickyPosition;
-        bool oldStyleIsSticky = oldStyle && oldStyle->position() == StickyPosition;
-
-        if (newStyleIsSticky != oldStyleIsSticky) {
-            if (newStyleIsSticky) {
-                frameView->addStickyPositionObject();
-                // During compositing inputs update we'll have the scroll
-                // ancestor without having to walk up the tree and can compute
-                // the sticky position constraints then.
-                if (layer())
-                    layer()->setNeedsCompositingInputsUpdate();
-            } else {
-                // This may get re-added to viewport constrained objects if the object went
-                // from sticky to fixed.
-                frameView->removeViewportConstrainedObject(this);
-                frameView->removeStickyPositionObject();
-
-                // Remove sticky constraints for this layer.
-                if (layer()) {
-                    DisableCompositingQueryAsserts disabler;
-                    if (const PaintLayer* ancestorOverflowLayer = layer()->ancestorOverflowLayer())
-                        ancestorOverflowLayer->getScrollableArea()->invalidateStickyConstraintsFor(layer());
-                }
-            }
-        }
-
+        bool newStyleIsViewportConstained = style()->hasViewportConstrainedPosition();
+        bool oldStyleIsViewportConstrained = oldStyle && oldStyle->hasViewportConstrainedPosition();
         if (newStyleIsViewportConstained != oldStyleIsViewportConstrained) {
             if (newStyleIsViewportConstained && layer())
                 frameView->addViewportConstrainedObject(this);
             else
                 frameView->removeViewportConstrainedObject(this);
         }
     }
 }
 
-void LayoutBoxModelObject::invalidateStickyConstraints()
-{
-    if (!layer())
-        return;
-
-    // This intentionally uses the stale ancestor overflow layer compositing
-    // input as if we have saved constraints for this layer they were saved
-    // in the previous frame.
-    DisableCompositingQueryAsserts disabler;
-    if (const PaintLayer* ancestorOverflowLayer = layer()->ancestorOverflowLayer())
-        ancestorOverflowLayer->getScrollableArea()->invalidateAllStickyConstraints();
-}
-
 void LayoutBoxModelObject::createLayer(PaintLayerType type)
 {
     // If the current paint invalidation container is not a stacking context and this object is
     // stacked content, creating this layer may cause this object and its
     // descendants to change paint invalidation container. Therefore we must eagerly invalidate
     // them on the original paint invalidation container before creating the layer.
     if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled() && isRooted() && styleRef().isStacked()) {
         const LayoutBoxModelObject& currentPaintInvalidationContainer = containerForPaintInvalidation();
         if (!currentPaintInvalidationContainer.styleRef().isStackingContext())
             invalidatePaintIncludingNonSelfPaintingLayerDescendants(currentPaintInvalidationContainer);
@@ skipping 299 matching lines @@
 
     else if (!style()->bottom().isAuto()
         && (!containingBlock->hasAutoHeightOrContainingBlockWithAutoHeight()
             || !style()->bottom().hasPercent()
             || containingBlock->stretchesToViewport()))
         offset.expand(LayoutUnit(), -valueForLength(style()->bottom(), containingBlock->availableHeight()));
 
     return offset;
 }
 
-void LayoutBoxModelObject::updateStickyPositionConstraints() const
-{
-    // TODO(flackr): This method is reasonably complicated and should have some direct unit testing.
-    const FloatSize constrainingSize = computeStickyConstrainingRect().size();
-
-    PaintLayerScrollableArea* scrollableArea = layer()->ancestorOverflowLayer()->getScrollableArea();
-    StickyPositionScrollingConstraints constraints;
-    FloatSize skippedContainersOffset;
-    LayoutBlock* containingBlock = this->containingBlock();
-    // Skip anonymous containing blocks.
-    while (containingBlock->isAnonymous()) {
-        skippedContainersOffset += toFloatSize(FloatPoint(containingBlock->frameRect().location()));
-        containingBlock = containingBlock->containingBlock();
-    }
-    LayoutBox* scrollAncestor = layer()->ancestorOverflowLayer()->isRootLayer() ? nullptr : toLayoutBox(layer()->ancestorOverflowLayer()->layoutObject());
-
-    LayoutRect containerContentRect = containingBlock->contentBoxRect();
-    LayoutUnit maxWidth = containingBlock->availableLogicalWidth();
-
-    // Sticky positioned element ignore any override logical width on the containing block (as they don't call
-    // containingBlockLogicalWidthForContent). It's unclear whether this is totally fine.
-    // Compute the container-relative area within which the sticky element is allowed to move.
-    containerContentRect.contractEdges(
-        minimumValueForLength(style()->marginTop(), maxWidth),
-        minimumValueForLength(style()->marginRight(), maxWidth),
-        minimumValueForLength(style()->marginBottom(), maxWidth),
-        minimumValueForLength(style()->marginLeft(), maxWidth));
-
-    // Map to the scroll ancestor.
-    constraints.setScrollContainerRelativeContainingBlockRect(containingBlock->localToAncestorQuad(FloatRect(containerContentRect), scrollAncestor).boundingBox());
-
-    FloatRect stickyBoxRect = isLayoutInline()
-        ? FloatRect(toLayoutInline(this)->linesBoundingBox())
-        : FloatRect(toLayoutBox(this)->frameRect());
-    FloatRect flippedStickyBoxRect = stickyBoxRect;
-    containingBlock->flipForWritingMode(flippedStickyBoxRect);
-    FloatPoint stickyLocation = flippedStickyBoxRect.location() + skippedContainersOffset;
-
-    // TODO(flackr): Unfortunate to call localToAncestorQuad again, but we can't just offset from the previously computed rect if there are transforms.
-    // Map to the scroll ancestor.
-    FloatRect scrollContainerRelativeContainerFrame = containingBlock->localToAncestorQuad(FloatRect(FloatPoint(), FloatSize(containingBlock->size())), scrollAncestor).boundingBox();
-
-    // If the containing block is our scroll ancestor, its location will not include the scroll offset which we need to include as
-    // part of the sticky box rect so we include it here.
-    if (containingBlock->hasOverflowClip()) {
-        FloatSize scrollOffset(toFloatSize(containingBlock->layer()->getScrollableArea()->adjustedScrollOffset()));
-        stickyLocation -= scrollOffset;
-    }
-
-    constraints.setScrollContainerRelativeStickyBoxRect(FloatRect(scrollContainerRelativeContainerFrame.location() + toFloatSize(stickyLocation), flippedStickyBoxRect.size()));
-
-    // We skip the right or top sticky offset if there is not enough space to honor both the left/right or top/bottom offsets.
-    LayoutUnit horizontalOffsets = minimumValueForLength(style()->right(), LayoutUnit(constrainingSize.width())) +
-        minimumValueForLength(style()->left(), LayoutUnit(constrainingSize.width()));
-    bool skipRight = false;
-    bool skipLeft = false;
-    if (!style()->left().isAuto() && !style()->right().isAuto()) {
-        if (horizontalOffsets > containerContentRect.width()
-            || horizontalOffsets + containerContentRect.width() > constrainingSize.width()) {
-            skipRight = style()->isLeftToRightDirection();
-            skipLeft = !skipRight;
-        }
-    }
-
-    if (!style()->left().isAuto() && !skipLeft) {
-        constraints.setLeftOffset(minimumValueForLength(style()->left(), LayoutUnit(constrainingSize.width())));
-        constraints.addAnchorEdge(StickyPositionScrollingConstraints::AnchorEdgeLeft);
-    }
-
-    if (!style()->right().isAuto() && !skipRight) {
-        constraints.setRightOffset(minimumValueForLength(style()->right(), LayoutUnit(constrainingSize.width())));
-        constraints.addAnchorEdge(StickyPositionScrollingConstraints::AnchorEdgeRight);
-    }
-
-    bool skipBottom = false;
-    // TODO(flackr): Exclude top or bottom edge offset depending on the writing mode when related
-    // sections are fixed in spec: http://lists.w3.org/Archives/Public/www-style/2014May/0286.html
-    LayoutUnit verticalOffsets = minimumValueForLength(style()->top(), LayoutUnit(constrainingSize.height())) +
-        minimumValueForLength(style()->bottom(), LayoutUnit(constrainingSize.height()));
-    if (!style()->top().isAuto() && !style()->bottom().isAuto()) {
-        if (verticalOffsets > containerContentRect.height()
-            || verticalOffsets + containerContentRect.height() > constrainingSize.height()) {
-            skipBottom = true;
-        }
-    }
-
-    if (!style()->top().isAuto()) {
-        constraints.setTopOffset(minimumValueForLength(style()->top(), LayoutUnit(constrainingSize.height())));
-        constraints.addAnchorEdge(StickyPositionScrollingConstraints::AnchorEdgeTop);
-    }
-
-    if (!style()->bottom().isAuto() && !skipBottom) {
-        constraints.setBottomOffset(minimumValueForLength(style()->bottom(), LayoutUnit(constrainingSize.height())));
-        constraints.addAnchorEdge(StickyPositionScrollingConstraints::AnchorEdgeBottom);
-    }
-    scrollableArea->stickyConstraintsMap().set(layer(), constraints);
-}
-
-FloatRect LayoutBoxModelObject::computeStickyConstrainingRect() const
-{
-    if (layer()->ancestorOverflowLayer()->isRootLayer())
-        return view()->frameView()->visibleContentRect();
-
-    LayoutBox* enclosingClippingBox = toLayoutBox(layer()->ancestorOverflowLayer()->layoutObject());
-    FloatRect constrainingRect;
-    constrainingRect = FloatRect(enclosingClippingBox->overflowClipRect(LayoutPoint()));
-    constrainingRect.move(enclosingClippingBox->paddingLeft(), enclosingClippingBox->paddingTop());
-    constrainingRect.contract(FloatSize(enclosingClippingBox->paddingLeft() + enclosingClippingBox->paddingRight(),
-        enclosingClippingBox->paddingTop() + enclosingClippingBox->paddingBottom()));
-    return constrainingRect;
-}
-
-LayoutSize LayoutBoxModelObject::stickyPositionOffset() const
-{
-    const PaintLayer* ancestorOverflowLayer = layer()->ancestorOverflowLayer();
-    // TODO: Force compositing input update if we ask for offset before compositing inputs have been computed?
-    if (!ancestorOverflowLayer)
-        return LayoutSize();
-    FloatRect constrainingRect = computeStickyConstrainingRect();
-    PaintLayerScrollableArea* scrollableArea = ancestorOverflowLayer->getScrollableArea();
-
-    // The sticky offset is physical, so we can just return the delta computed in absolute coords (though it may be wrong with transforms).
-    // TODO: Force compositing input update if we ask for offset with stale compositing inputs.
-    if (!scrollableArea->stickyConstraintsMap().contains(layer()))
-        return LayoutSize();
-    return LayoutSize(scrollableArea->stickyConstraintsMap().get(layer()).computeStickyOffset(constrainingRect));
-}
-
 LayoutPoint LayoutBoxModelObject::adjustedPositionRelativeToOffsetParent(const LayoutPoint& startPoint) const
 {
     // If the element is the HTML body element or doesn't have a parent
     // return 0 and stop this algorithm.
     if (isBody() || !parent())
         return LayoutPoint();
 
     LayoutPoint referencePoint = startPoint;
     referencePoint.move(parent()->columnOffset(referencePoint));
 
     // If the offsetParent of the element is null, or is the HTML body element,
     // return the distance between the canvas origin and the left border edge
     // of the element and stop this algorithm.
     Element* element = offsetParent();
     if (!element)
         return referencePoint;
 
     if (const LayoutBoxModelObject* offsetParent = element->layoutBoxModelObject()) {
         if (offsetParent->isBox() && !offsetParent->isBody())
             referencePoint.move(-toLayoutBox(offsetParent)->borderLeft(), -toLayoutBox(offsetParent)->borderTop());
         if (!isOutOfFlowPositioned() || flowThreadContainingBlock()) {
             if (isInFlowPositioned())
-                referencePoint.move(offsetForInFlowPosition());
+                referencePoint.move(relativePositionOffset());
 
             LayoutObject* current;
             for (current = parent(); current != offsetParent && current->parent(); current = current->parent()) {
                 // FIXME: What are we supposed to do inside SVG content?
                 if (!isOutOfFlowPositioned()) {
                     if (current->isBox() && !current->isTableRow())
                         referencePoint.moveBy(toLayoutBox(current)->topLeftLocation());
                     referencePoint.move(current->parent()->columnOffset(referencePoint));
                 }
             }
 
             if (offsetParent->isBox() && offsetParent->isBody() && !offsetParent->isPositioned())
                 referencePoint.moveBy(toLayoutBox(offsetParent)->topLeftLocation());
         }
     }
 
     return referencePoint;
 }
 
 LayoutSize LayoutBoxModelObject::offsetForInFlowPosition() const
 {
-    if (isRelPositioned())
-        return relativePositionOffset();
-
-    if (isStickyPositioned())
-        return stickyPositionOffset();
-
-    return LayoutSize();
+    return isRelPositioned() ? relativePositionOffset() : LayoutSize();
 }
 
 LayoutUnit LayoutBoxModelObject::offsetLeft() const
 {
     // Note that LayoutInline and LayoutBox override this to pass a different
     // startPoint to adjustedPositionRelativeToOffsetParent.
     return adjustedPositionRelativeToOffsetParent(LayoutPoint()).x();
 }
 
 LayoutUnit LayoutBoxModelObject::offsetTop() const
@@ skipping 218 matching lines @@
     if (offsetDependsOnPoint)
         flags |= IsNonUniform;
     if (isFixedPos)
         flags |= IsFixedPosition;
     if (hasTransform)
         flags |= HasTransform;
     if (shouldUseTransformFromContainer(container)) {
         TransformationMatrix t;
         getTransformFromContainer(container, containerOffset, t);
         t.translateRight(adjustmentForSkippedAncestor.width().toFloat(), adjustmentForSkippedAncestor.height().toFloat());
-        geometryMap.push(this, t, flags, LayoutSize());
+        geometryMap.push(this, t, flags);
     } else {
         containerOffset += adjustmentForSkippedAncestor;
-        geometryMap.push(this, containerOffset, flags, LayoutSize());
+        geometryMap.push(this, containerOffset, flags);
     }
 
     return ancestorSkipped ? ancestorToStopAt : container;
 }
 
 void LayoutBoxModelObject::moveChildTo(LayoutBoxModelObject* toBoxModelObject, LayoutObject* child, LayoutObject* beforeChild, bool fullRemoveInsert)
 {
     // We assume that callers have cleared their positioned objects list for child moves (!fullRemoveInsert) so the
     // positioned layoutObject maps don't become stale. It would be too slow to do the map lookup on each call.
     ASSERT(!fullRemoveInsert || !isLayoutBlock() || !toLayoutBlock(this)->hasPositionedObjects());
@@ skipping 61 matching lines @@
     if (rootElementStyle->hasBackground())
         return false;
 
     if (node() != document().firstBodyElement())
         return false;
 
     return true;
 }
 
 } // namespace blink