Issue 185063005: Revert of DevTools: Do not save split view size on show mode changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 185063005: Revert of DevTools: Do not save split view size on show mode changes. (Closed)

Created:
6 years, 9 months ago by pfeldman

Modified:
6 years, 9 months ago

Reviewers:
vsevik, dgozman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert of DevTools: Do not save split view size on show mode changes. (https://codereview.chromium.org/185943004/) Reason for revert: Split location is no longer persisted. Original issue's description: > DevTools: Do not save split view size on show mode changes. > > BUG=348887 > R=dgozman > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168608 TBR=dgozman@chromium.org,vsevik@chromium.org NOTREECHECKS=true NOTRY=true BUG=348887 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168626

Patch Set 1 #

Created: 6 years, 9 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -28 lines)			Patch
	M	LayoutTests/http/tests/inspector/network/network-sidebar-width.html	View		2 chunks	+0 lines, -8 lines	0 comments	Download
	M	Source/devtools/front_end/SplitView.js	View		10 chunks	+21 lines, -20 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

pfeldman

Created Revert of DevTools: Do not save split view size on show mode changes.

6 years, 9 months ago (2014-03-06 11:50:49 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/185063005/1

6 years, 9 months ago (2014-03-06 11:51:03 UTC) #2

pfeldman

6 years, 9 months ago (2014-03-06 11:51:32 UTC) #4

Message was sent while issue was closed.

On 2014/03/06 11:50:49, pfeldman wrote:
> Created Revert of DevTools: Do not save split view size on show mode changes.

Next time lets land along with the test.

Expand Messages | Collapse Messages