Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: LayoutTests/http/tests/inspector/network/network-sidebar-width.html

Issue 185063005: Revert of DevTools: Do not save split view size on show mode changes. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/devtools/front_end/SplitView.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <html> 1 <html>
2 <head> 2 <head>
3 <script src="../inspector-test.js"></script> 3 <script src="../inspector-test.js"></script>
4 <script src="../network-test.js"></script> 4 <script src="../network-test.js"></script>
5 <script> 5 <script>
6 function test() 6 function test()
7 { 7 {
8 InspectorTest.recordNetwork(); 8 InspectorTest.recordNetwork();
9 InspectorTest.makeSimpleXHR("GET", "resources/resource.php", true, step2); 9 InspectorTest.makeSimpleXHR("GET", "resources/resource.php", true, step2);
10 10
11 var oldSetting; 11 var oldSetting;
12 function step2() 12 function step2()
13 { 13 {
14 var panel = WebInspector.panel("network"); 14 var panel = WebInspector.panel("network");
15 var settingName = "networkPanelSplitViewState"; 15 var settingName = "networkPanelSplitViewState";
16 var setting = WebInspector.settings.createSetting(settingName, undefined ); 16 var setting = WebInspector.settings.createSetting(settingName, undefined );
17 WebInspector.settings[settingName] = setting; 17 WebInspector.settings[settingName] = setting;
18 var request = WebInspector.panel("network").requests[WebInspector.panel( "network").requests.length - 1]; 18 var request = WebInspector.panel("network").requests[WebInspector.panel( "network").requests.length - 1];
19 19
20 settingValue = setting.get(); 20 settingValue = setting.get();
21 settingValue.vertical = settingValue.vertical || {}; 21 settingValue.vertical = settingValue.vertical || {};
22 var oldSize = settingValue.vertical.size; 22 var oldSize = settingValue.vertical.size;
23 WebInspector.inspectorView.showPanel("network"); 23 WebInspector.inspectorView.showPanel("network");
24 24
25 delete settingValue.vertical.size; 25 delete settingValue.vertical.size;
26 setting.set(settingValue); 26 setting.set(settingValue);
27 forceSettingRead(panel._splitView);
28 panel._showRequest(request); 27 panel._showRequest(request);
29 InspectorTest.addResult("Sidebar width: " + panel._splitView.sidebarElem ent().offsetWidth); 28 InspectorTest.addResult("Sidebar width: " + panel._splitView.sidebarElem ent().offsetWidth);
30 panel._toggleGridMode(); 29 panel._toggleGridMode();
31 30
32 settingValue.vertical.size = 242; 31 settingValue.vertical.size = 242;
33 setting.set(settingValue); 32 setting.set(settingValue);
34 forceSettingRead(panel._splitView);
35 panel._showRequest(request); 33 panel._showRequest(request);
36 InspectorTest.addResult("Sidebar width: " + panel._splitView.sidebarElem ent().offsetWidth); 34 InspectorTest.addResult("Sidebar width: " + panel._splitView.sidebarElem ent().offsetWidth);
37 panel._closeVisibleRequest(request); 35 panel._closeVisibleRequest(request);
38 36
39 settingValue.vertical.size = oldSize; 37 settingValue.vertical.size = oldSize;
40 setting.set(settingValue); 38 setting.set(settingValue);
41 39
42 InspectorTest.completeTest(); 40 InspectorTest.completeTest();
43 } 41 }
44
45 function forceSettingRead(splitView)
46 {
47 splitView.setVertical(false);
48 splitView.setVertical(true);
49 }
50 } 42 }
51 </script> 43 </script>
52 </head> 44 </head>
53 <body onload="runTest()"> 45 <body onload="runTest()">
54 <p>Tests network panel sidebar width with and without preference set.</p> 46 <p>Tests network panel sidebar width with and without preference set.</p>
55 <a href="https://bugs.webkit.org/show_bug.cgi?id=65256">Bug 65256</a> 47 <a href="https://bugs.webkit.org/show_bug.cgi?id=65256">Bug 65256</a>
56 </body> 48 </body>
57 </html> 49 </html>
OLDNEW
« no previous file with comments | « no previous file | Source/devtools/front_end/SplitView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698