Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 1850543002: Add inline completion to quicklaunch (Closed)

Created:
4 years, 8 months ago by Ben Goodger (Google)
Modified:
4 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@58tv
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add inline completion to quicklaunch R=sky@chromium.org BUG= Committed: https://crrev.com/5aaf128d3a64093322e48cee4b934d78a1dcdb4c Cr-Commit-Position: refs/heads/master@{#384404}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 3

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -27 lines) Patch
M mash/quick_launch/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mash/quick_launch/quick_launch_application.h View 2 chunks +1 line, -1 line 0 comments Download
M mash/quick_launch/quick_launch_application.cc View 1 2 3 4 5 chunks +63 lines, -11 lines 0 comments Download
M mojo/services/catalog/catalog.cc View 1 2 3 3 chunks +25 lines, -14 lines 0 comments Download
M mojo/services/catalog/public/interfaces/catalog.mojom View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
Ben Goodger (Google)
4 years, 8 months ago (2016-03-31 17:19:47 UTC) #1
sky
LGTM https://codereview.chromium.org/1850543002/diff/40001/mash/quick_launch/quick_launch_application.cc File mash/quick_launch/quick_launch_application.cc (right): https://codereview.chromium.org/1850543002/diff/40001/mash/quick_launch/quick_launch_application.cc#newcode73 mash/quick_launch/quick_launch_application.cc:73: case ui::VKEY_RETURN: { nit: run git cl format ...
4 years, 8 months ago (2016-03-31 17:29:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1850543002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1850543002/60001
4 years, 8 months ago (2016-03-31 17:38:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/151638)
4 years, 8 months ago (2016-03-31 18:07:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1850543002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1850543002/80001
4 years, 8 months ago (2016-03-31 19:11:59 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-03-31 21:49:37 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 21:51:05 UTC) #13
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/5aaf128d3a64093322e48cee4b934d78a1dcdb4c
Cr-Commit-Position: refs/heads/master@{#384404}

Powered by Google App Engine
This is Rietveld 408576698