Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issue 1844973002: Implement a system-level entry cache so that packages loaded from the system dir can be visible to … (Closed)

Created:
4 years, 8 months ago by Ben Goodger (Google)
Modified:
4 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement a system-level entry cache so that packages loaded from the system dir can be visible to all user catalogs. This fixes the blank entries in the task viewer. R=sky@chromium.org BUG= Committed: https://crrev.com/854e857c5ab4f9994f1d85ccf3f7870300682889 Cr-Commit-Position: refs/heads/master@{#384083}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -32 lines) Patch
M mojo/mojo_shell.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/catalog/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/catalog/catalog.h View 1 4 chunks +12 lines, -6 lines 0 comments Download
M mojo/services/catalog/catalog.cc View 7 chunks +47 lines, -25 lines 1 comment Download
M mojo/services/catalog/factory.h View 2 chunks +3 lines, -0 lines 0 comments Download
M mojo/services/catalog/factory.cc View 1 chunk +2 lines, -1 line 0 comments Download
A mojo/services/catalog/types.h View 1 1 chunk +22 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Ben Goodger (Google)
4 years, 8 months ago (2016-03-30 18:06:16 UTC) #1
sky
LGTM https://codereview.chromium.org/1844973002/diff/20001/mojo/services/catalog/catalog.cc File mojo/services/catalog/catalog.cc (right): https://codereview.chromium.org/1844973002/diff/20001/mojo/services/catalog/catalog.cc#newcode224 mojo/services/catalog/catalog.cc:224: result->package_dir == catalog->system_package_dir_); nit: spacing is off.
4 years, 8 months ago (2016-03-30 18:46:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844973002/20001
4 years, 8 months ago (2016-03-30 20:39:52 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-30 20:45:03 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 20:46:20 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/854e857c5ab4f9994f1d85ccf3f7870300682889
Cr-Commit-Position: refs/heads/master@{#384083}

Powered by Google App Engine
This is Rietveld 408576698