Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 185053006: Refactor of QUIC's rtt storage and calculation to have a single RttStats (Closed)

Created:
6 years, 9 months ago by ramant (doing other things)
Modified:
6 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, Ian Swett
Visibility:
Public.

Description

Refactor of QUIC's rtt storage and calculation to have a single RttStats object used by the SentPacketManager, LossDetectionAlgorithms, and SendAlgorithms. Merge internal change: 62624956 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -271 lines) Patch
M net/net.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/congestion_control/fix_rate_sender.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/congestion_control/fix_rate_sender.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M net/quic/congestion_control/inter_arrival_sender.h View 3 chunks +2 lines, -2 lines 0 comments Download
M net/quic/congestion_control/inter_arrival_sender.cc View 8 chunks +15 lines, -38 lines 0 comments Download
M net/quic/congestion_control/inter_arrival_sender_test.cc View 3 chunks +4 lines, -1 line 0 comments Download
M net/quic/congestion_control/loss_detection_interface.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/congestion_control/pacing_sender.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/congestion_control/pacing_sender.cc View 1 chunk +0 lines, -4 lines 0 comments Download
A net/quic/congestion_control/rtt_stats.h View 1 chunk +61 lines, -0 lines 0 comments Download
A net/quic/congestion_control/rtt_stats.cc View 1 chunk +81 lines, -0 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.h View 2 chunks +5 lines, -3 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.h View 5 chunks +4 lines, -12 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 7 chunks +14 lines, -55 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_test.cc View 5 chunks +15 lines, -9 lines 0 comments Download
M net/quic/congestion_control/tcp_loss_algorithm.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/congestion_control/tcp_loss_algorithm.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/congestion_control/tcp_loss_algorithm_test.cc View 7 chunks +14 lines, -11 lines 0 comments Download
M net/quic/congestion_control/time_loss_algorithm.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/congestion_control/time_loss_algorithm.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M net/quic/congestion_control/time_loss_algorithm_test.cc View 11 chunks +17 lines, -14 lines 0 comments Download
M net/quic/quic_connection_test.cc View 25 chunks +24 lines, -27 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/quic_sent_packet_manager.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 6 chunks +10 lines, -22 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 16 chunks +30 lines, -36 lines 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ramant (doing other things)
6 years, 9 months ago (2014-03-06 03:39:05 UTC) #1
ramant (doing other things)
Hi Ryan and Ian, In quic_connection_test.cc, we have deleted the ECPECT_CALL for SmoothedRtt. Did the ...
6 years, 9 months ago (2014-03-06 03:43:57 UTC) #2
Ryan Hamilton
6 years, 9 months ago (2014-03-06 05:09:41 UTC) #3
On 2014/03/06 03:43:57, ramant wrote:
> Hi Ryan and Ian,
>   In quic_connection_test.cc, we have deleted the ECPECT_CALL for SmoothedRtt.
> Did the same in quic_http_stream_test.cc and all unit tests compiled/passed.
> 
> Is it the right thing to do?
> 
> EXPECT_CALL(*send_algorithm_,SmoothedRtt()).WillRepeatedly(Return(.....
> 
> thanks much
> raman

Yup, LGTM.

Powered by Google App Engine
This is Rietveld 408576698