Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 1850413002: Improve DEFINE_STATIC_LOCAL()'s handling of Blink GCed objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address compilation failure Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
index 9e0fa545ec1bec49b313ed9f9cb18d4e5505d42c..27fa34f8bf466e20188e9c92f00bab16ad731c20 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
@@ -818,13 +818,8 @@ void ComputedStyle::updatePropertySpecificDifferences(const ComputedStyle& other
void ComputedStyle::addCursor(RawPtr<StyleImage> image, bool hotSpotSpecified, const IntPoint& hotSpot)
{
- if (!rareInheritedData.access()->cursorData) {
-#if ENABLE(OILPAN)
+ if (!rareInheritedData.access()->cursorData)
rareInheritedData.access()->cursorData = new CursorList;
-#else
- rareInheritedData.access()->cursorData = CursorList::create();
-#endif
- }
rareInheritedData.access()->cursorData->append(CursorData(image, hotSpotSpecified, hotSpot));
}
@@ -1744,19 +1739,17 @@ Color ComputedStyle::initialTapHighlightColor()
return LayoutTheme::tapHighlightColor();
}
-#if ENABLE(OILPAN)
const FilterOperations& ComputedStyle::initialFilter()
{
- DEFINE_STATIC_LOCAL(Persistent<FilterOperationsWrapper>, ops, (FilterOperationsWrapper::create()));
- return ops->operations();
+ DEFINE_STATIC_LOCAL(FilterOperationsWrapper, ops, (FilterOperationsWrapper::create()));
+ return ops.operations();
}
const FilterOperations& ComputedStyle::initialBackdropFilter()
{
- DEFINE_STATIC_LOCAL(Persistent<FilterOperationsWrapper>, ops, (FilterOperationsWrapper::create()));
- return ops->operations();
+ DEFINE_STATIC_LOCAL(FilterOperationsWrapper, ops, (FilterOperationsWrapper::create()));
+ return ops.operations();
}
-#endif
LayoutRectOutsets ComputedStyle::imageOutsets(const NinePieceImage& image) const
{
« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.h ('k') | third_party/WebKit/Source/core/svg/SVGElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698