Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 1850413002: Improve DEFINE_STATIC_LOCAL()'s handling of Blink GCed objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address compilation failure Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org) 2 * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
4 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved. 4 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 800 matching lines...) Expand 10 before | Expand all | Expand 10 after
811 || rareInheritedData->visitedLinkTextEmphasisColor() != other.ra reInheritedData->visitedLinkTextEmphasisColor() 811 || rareInheritedData->visitedLinkTextEmphasisColor() != other.ra reInheritedData->visitedLinkTextEmphasisColor()
812 || rareInheritedData->textEmphasisFill != other.rareInheritedDat a->textEmphasisFill 812 || rareInheritedData->textEmphasisFill != other.rareInheritedDat a->textEmphasisFill
813 || rareInheritedData->appliedTextDecorations != other.rareInheri tedData->appliedTextDecorations)) { 813 || rareInheritedData->appliedTextDecorations != other.rareInheri tedData->appliedTextDecorations)) {
814 diff.setTextDecorationOrColorChanged(); 814 diff.setTextDecorationOrColorChanged();
815 } 815 }
816 } 816 }
817 } 817 }
818 818
819 void ComputedStyle::addCursor(RawPtr<StyleImage> image, bool hotSpotSpecified, c onst IntPoint& hotSpot) 819 void ComputedStyle::addCursor(RawPtr<StyleImage> image, bool hotSpotSpecified, c onst IntPoint& hotSpot)
820 { 820 {
821 if (!rareInheritedData.access()->cursorData) { 821 if (!rareInheritedData.access()->cursorData)
822 #if ENABLE(OILPAN)
823 rareInheritedData.access()->cursorData = new CursorList; 822 rareInheritedData.access()->cursorData = new CursorList;
824 #else
825 rareInheritedData.access()->cursorData = CursorList::create();
826 #endif
827 }
828 rareInheritedData.access()->cursorData->append(CursorData(image, hotSpotSpec ified, hotSpot)); 823 rareInheritedData.access()->cursorData->append(CursorData(image, hotSpotSpec ified, hotSpot));
829 } 824 }
830 825
831 void ComputedStyle::setCursorList(RawPtr<CursorList> other) 826 void ComputedStyle::setCursorList(RawPtr<CursorList> other)
832 { 827 {
833 rareInheritedData.access()->cursorData = other; 828 rareInheritedData.access()->cursorData = other;
834 } 829 }
835 830
836 void ComputedStyle::setQuotes(PassRefPtr<QuotesData> q) 831 void ComputedStyle::setQuotes(PassRefPtr<QuotesData> q)
837 { 832 {
(...skipping 899 matching lines...) Expand 10 before | Expand all | Expand 10 after
1737 return TextEmphasisMarkDot; 1732 return TextEmphasisMarkDot;
1738 1733
1739 return TextEmphasisMarkSesame; 1734 return TextEmphasisMarkSesame;
1740 } 1735 }
1741 1736
1742 Color ComputedStyle::initialTapHighlightColor() 1737 Color ComputedStyle::initialTapHighlightColor()
1743 { 1738 {
1744 return LayoutTheme::tapHighlightColor(); 1739 return LayoutTheme::tapHighlightColor();
1745 } 1740 }
1746 1741
1747 #if ENABLE(OILPAN)
1748 const FilterOperations& ComputedStyle::initialFilter() 1742 const FilterOperations& ComputedStyle::initialFilter()
1749 { 1743 {
1750 DEFINE_STATIC_LOCAL(Persistent<FilterOperationsWrapper>, ops, (FilterOperati onsWrapper::create())); 1744 DEFINE_STATIC_LOCAL(FilterOperationsWrapper, ops, (FilterOperationsWrapper:: create()));
1751 return ops->operations(); 1745 return ops.operations();
1752 } 1746 }
1753 1747
1754 const FilterOperations& ComputedStyle::initialBackdropFilter() 1748 const FilterOperations& ComputedStyle::initialBackdropFilter()
1755 { 1749 {
1756 DEFINE_STATIC_LOCAL(Persistent<FilterOperationsWrapper>, ops, (FilterOperati onsWrapper::create())); 1750 DEFINE_STATIC_LOCAL(FilterOperationsWrapper, ops, (FilterOperationsWrapper:: create()));
1757 return ops->operations(); 1751 return ops.operations();
1758 } 1752 }
1759 #endif
1760 1753
1761 LayoutRectOutsets ComputedStyle::imageOutsets(const NinePieceImage& image) const 1754 LayoutRectOutsets ComputedStyle::imageOutsets(const NinePieceImage& image) const
1762 { 1755 {
1763 return LayoutRectOutsets( 1756 return LayoutRectOutsets(
1764 NinePieceImage::computeOutset(image.outset().top(), borderTopWidth()), 1757 NinePieceImage::computeOutset(image.outset().top(), borderTopWidth()),
1765 NinePieceImage::computeOutset(image.outset().right(), borderRightWidth() ), 1758 NinePieceImage::computeOutset(image.outset().right(), borderRightWidth() ),
1766 NinePieceImage::computeOutset(image.outset().bottom(), borderBottomWidth ()), 1759 NinePieceImage::computeOutset(image.outset().bottom(), borderBottomWidth ()),
1767 NinePieceImage::computeOutset(image.outset().left(), borderLeftWidth())) ; 1760 NinePieceImage::computeOutset(image.outset().left(), borderLeftWidth())) ;
1768 } 1761 }
1769 1762
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
1860 if (!shadowList) 1853 if (!shadowList)
1861 return false; 1854 return false;
1862 for (size_t i = shadowList->shadows().size(); i--; ) { 1855 for (size_t i = shadowList->shadows().size(); i--; ) {
1863 if (shadowList->shadows()[i].color().isCurrentColor()) 1856 if (shadowList->shadows()[i].color().isCurrentColor())
1864 return true; 1857 return true;
1865 } 1858 }
1866 return false; 1859 return false;
1867 } 1860 }
1868 1861
1869 } // namespace blink 1862 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.h ('k') | third_party/WebKit/Source/core/svg/SVGElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698