Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 18503004: Have SVGTextContentElement inherit SVGGraphicsElement (Closed)

Created:
7 years, 5 months ago by do-not-use
Modified:
7 years, 5 months ago
Reviewers:
pdr., krit, Stephen Chennney
CC:
blink-reviews, eae+blinkwatch, dglazkov+blink, f(malita), pdr, Stephen Chennney, do-not-use, lgombos, haraken
Visibility:
Public.

Description

Have SVGTextContentElement inherit SVGGraphicsElement Have SVGTextContentElement inherit SVGGraphicsElement instead of SVGStyledElement in order to match the latest SVG2 specification: https://svgwg.org/svg2-draft/text.html#InterfaceSVGTextContentElement This patch also removes the SVGTransformable and SVGLocatable IDL interfaces as they are no longer needed (were merged into SVGGraphicsElement in the latest specification). Conversion to absolute (user agent) coordinates in the svg/text tests is fixed to use SVGGraphicsElement::getScreenCTM() instead of SVGGraphicsElement::getTransformToElement(). The previous code was working until now due to a bug in getTransformToElement(), which was not taking into consideration the CTM of the SVGTextElement (as it was not recognized as a "locatable" element). Now that SVGTextElement inherits from SVGGraphicsElement, it is properly recognized as a "locatable" element by getTransformToElement(). This is one step towards getting rid of multiple inheritance in SVG. BUG=256600 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153432

Patch Set 1 #

Patch Set 2 : Remove SVGLocatable IDL interface #

Patch Set 3 : Really remove SVGLocatable IDL interface #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -213 lines) Patch
M LayoutTests/svg/text/resources/SelectionTestCase.js View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/svg/text/selection-doubleclick.svg View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimateMotionElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGElement.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
D Source/core/svg/SVGLocatable.idl View 1 2 1 chunk +0 lines, -38 lines 0 comments Download
M Source/core/svg/SVGTextContentElement.h View 3 chunks +2 lines, -9 lines 0 comments Download
M Source/core/svg/SVGTextContentElement.cpp View 4 chunks +6 lines, -7 lines 0 comments Download
M Source/core/svg/SVGTextContentElement.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGTextElement.h View 2 chunks +1 line, -24 lines 0 comments Download
M Source/core/svg/SVGTextElement.cpp View 4 chunks +5 lines, -93 lines 0 comments Download
M Source/core/svg/SVGTextElement.idl View 1 chunk +1 line, -2 lines 0 comments Download
D Source/core/svg/SVGTransformable.idl View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
do-not-use
7 years, 5 months ago (2013-07-02 11:36:37 UTC) #1
Stephen Chennney
lgtm
7 years, 5 months ago (2013-07-02 16:24:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/18503004/6001
7 years, 5 months ago (2013-07-02 16:24:55 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-02 17:50:52 UTC) #4
Message was sent while issue was closed.
Change committed as 153432

Powered by Google App Engine
This is Rietveld 408576698