Source/core/svg/SVGAnimateMotionElement.cpp - Issue 18503004: Have SVGTextContentElement inherit SVGGraphicsElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGAnimateMotionElement.cpp

Issue 18503004: Have SVGTextContentElement inherit SVGGraphicsElement (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Really remove SVGLocatable IDL interface Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGAnimateMotionElement.cpp

diff --git a/Source/core/svg/SVGAnimateMotionElement.cpp b/Source/core/svg/SVGAnimateMotionElement.cpp

index ceda949bd3679d00ba1cc9535f04a856e160e735..1a468f3a8a096ab239e0acf843dfbb7d80cd1de5 100644

--- a/Source/core/svg/SVGAnimateMotionElement.cpp

+++ b/Source/core/svg/SVGAnimateMotionElement.cpp

@@ -60,7 +60,7 @@ bool SVGAnimateMotionElement::hasValidAttributeType()

return false;

// We don't have a special attribute name to verify the animation type. Check the element name instead.

- if (!targetElement->isSVGGraphicsElement() && !targetElement->hasTagName(SVGNames::textTag))

+ if (!targetElement->isSVGGraphicsElement())

return false;

// Spec: SVG 1.1 section 19.2.15

// FIXME: svgTag is missing. Needs to be checked, if transforming <svg> could cause problems.

« no previous file with comments | « LayoutTests/svg/text/selection-doubleclick.svg ('k') | Source/core/svg/SVGElement.cpp » ('j') | no next file with comments »