[Mac] Drop shadow for Omnibox popup.

[Mac] Drop shadow for Omnibox popup.

Adding the system drop shadow adds a border, so removed the border we
were drawing.  Also pushed all of the one-pixel-here-one-pixel-there
positioning tweaks to -autocompletePopupPosition.

http://crbug.com/20283
TEST=Omnibox popup border should have drop shadow, be two pixels below
Omnibox, and rounded corners should align with rounded corners of star
and go buttons.

[rohitrao (ping after 24h), 2009-09-03 17:51:54]

http://codereview.chromium.org/185013/diff/1/2
File chrome/browser/autocomplete/autocomplete_popup_view_mac.mm (left):

http://codereview.chromium.org/185013/diff/1/2#oldcode659
Line 659: [[NSColor lightGrayColor] setStroke];
Why don't we need to draw the background or border anymore?

[Scott Hess - ex-Googler, 2009-09-03 18:08:07]

http://codereview.chromium.org/185013/diff/1/2
File chrome/browser/autocomplete/autocomplete_popup_view_mac.mm (left):

http://codereview.chromium.org/185013/diff/1/2#oldcode659
Line 659: [[NSColor lightGrayColor] setStroke];
On 2009/09/03 17:51:54, rohitrao wrote:
> Why don't we need to draw the background or border anymore?

-setBackgroundColor: in the window setup handles background.  Apparently
-setHasShadow: provides the border.  When I first enabled it, the border became
super-duper janky, and jrg indicated that he discovered the double border when
he did the drop shadow on the bookmark bubble.

[rohitrao (ping after 24h), 2009-09-03 18:10:54]

Ok, thanks for the explanation.

LGTM

[Scott Hess - ex-Googler, 2009-09-03 18:45:12]

http://codereview.chromium.org/185013/diff/4001/4002
File chrome/browser/autocomplete/autocomplete_popup_view_mac.mm (right):

http://codereview.chromium.org/185013/diff/4001/4002#newcode639
Line 639: }
Oops - looks like I had forgotten a bit in my clean-up pass.  Because when I did
my last-chance "Does it really work" test, my popup had square borders :-).

[rohitrao (ping after 24h), 2009-09-04 18:28:18]

LGTM