Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 185013: [Mac] Drop shadow for Omnibox popup. (Closed)

Created:
11 years, 3 months ago by Scott Hess - ex-Googler
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

[Mac] Drop shadow for Omnibox popup. Adding the system drop shadow adds a border, so removed the border we were drawing. Also pushed all of the one-pixel-here-one-pixel-there positioning tweaks to -autocompletePopupPosition. http://crbug.com/20283 TEST=Omnibox popup border should have drop shadow, be two pixels below Omnibox, and rounded corners should align with rounded corners of star and go buttons.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Oops, another CL masked something. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -22 lines) Patch
M chrome/browser/autocomplete/autocomplete_popup_view_mac.mm View 1 3 chunks +9 lines, -17 lines 1 comment Download
M chrome/browser/cocoa/toolbar_controller.mm View 1 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Scott Hess - ex-Googler
11 years, 3 months ago (2009-09-02 20:57:09 UTC) #1
rohitrao (ping after 24h)
http://codereview.chromium.org/185013/diff/1/2 File chrome/browser/autocomplete/autocomplete_popup_view_mac.mm (left): http://codereview.chromium.org/185013/diff/1/2#oldcode659 Line 659: [[NSColor lightGrayColor] setStroke]; Why don't we need to ...
11 years, 3 months ago (2009-09-03 17:51:54 UTC) #2
Scott Hess - ex-Googler
http://codereview.chromium.org/185013/diff/1/2 File chrome/browser/autocomplete/autocomplete_popup_view_mac.mm (left): http://codereview.chromium.org/185013/diff/1/2#oldcode659 Line 659: [[NSColor lightGrayColor] setStroke]; On 2009/09/03 17:51:54, rohitrao wrote: ...
11 years, 3 months ago (2009-09-03 18:08:07 UTC) #3
rohitrao (ping after 24h)
Ok, thanks for the explanation. LGTM
11 years, 3 months ago (2009-09-03 18:10:54 UTC) #4
Scott Hess - ex-Googler
http://codereview.chromium.org/185013/diff/4001/4002 File chrome/browser/autocomplete/autocomplete_popup_view_mac.mm (right): http://codereview.chromium.org/185013/diff/4001/4002#newcode639 Line 639: } Oops - looks like I had forgotten ...
11 years, 3 months ago (2009-09-03 18:45:12 UTC) #5
rohitrao (ping after 24h)
11 years, 3 months ago (2009-09-04 18:28:18 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698