[Mac] Drop shadow for Omnibox popup.

chrome/browser/autocomplete/autocomplete_popup_view_mac.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/autocomplete_popup_view_mac.h"
 
 #include "app/gfx/text_elider.h"
 #include "base/sys_string_conversions.h"
 #include "base/gfx/rect.h"
 #include "chrome/browser/autocomplete/autocomplete_edit.h"
@@ skipping 276 matching lines @@
   return [popup_ isVisible] ? true : false;
 }
 
 void AutocompletePopupViewMac::CreatePopupIfNeeded() {
   if (!popup_) {
     popup_.reset([[NSWindow alloc] initWithContentRect:NSZeroRect
                                              styleMask:NSBorderlessWindowMask
                                                backing:NSBackingStoreBuffered
                                                  defer:YES]);
     [popup_ setMovableByWindowBackground:NO];
-    // The window will have rounded borders.
+    // The window shape is determined by the content view
+    // (AutocompleteMatrix).
     [popup_ setAlphaValue:1.0];
     [popup_ setOpaque:NO];
+    [popup_ setBackgroundColor:[NSColor clearColor]];
+    [popup_ setHasShadow:YES];
     [popup_ setLevel:NSNormalWindowLevel];
 
     AutocompleteMatrix* matrix =
         [[[AutocompleteMatrix alloc] initWithFrame:NSZeroRect] autorelease];
     [matrix setTarget:matrix_target_];
     [matrix setAction:@selector(select:)];
     [matrix setMiddleClickAction:@selector(middleSelect:)];
     [popup_ setContentView:matrix];
 
     // We need the popup to follow window resize.
@@ skipping 314 matching lines @@
       return i;
     }
   }
   return -1;
 }
 
 - (void)setMiddleClickAction:(SEL)anAction {
   middleClickAction_ = anAction;
 }
 
+- (BOOL)isOpaque {
+  return NO;
+}

[Scott Hess - ex-Googler, 2009/09/03 18:45:12]

Oops - looks like I had forgotten a bit in my clean-up pass.  Because when I did
my last-chance "Does it really work" test, my popup had square borders :-).

+
 // This handles drawing the decorations of the rounded popup window,
 // calling on NSMatrix to draw the actual contents.
 - (void)drawRect:(NSRect)rect {
-  // Background clear so we can round the corners.
-  [[NSColor clearColor] set];
-  NSRectFill([self frame]);
-
-  // The toolbar items we're mirroring for shape are inset slightly
-  // for width.  I don't know why, which is why I didn't make this a
-  // constant, yet.  The factor of 0.5 on both dimensions is to put
-  // the stroke down the middle of the pixels.
-  const NSRect border(NSInsetRect([self bounds], 1.5, 0.5));
   NSBezierPath* path =
-      [NSBezierPath bezierPathWithRoundedRect:border
+      [NSBezierPath bezierPathWithRoundedRect:[self bounds]
                                       xRadius:kPopupRoundingRadius
                                       yRadius:kPopupRoundingRadius];
 
   // Draw the matrix clipped to our border.
   [NSGraphicsContext saveGraphicsState];
   [path addClip];
   [super drawRect:rect];
   [NSGraphicsContext restoreGraphicsState];
-
-  // Put a border over that.
-  // TODO(shess): Theme the color?
-  [[NSColor lightGrayColor] setStroke];
-  [path setLineWidth:1.0];
-  [path stroke];
 }
 
 @end
 
 @implementation AutocompleteMatrixTarget
 
 - initWithPopupView:(AutocompletePopupViewMac*)view {
   self = [super init];
   if (self) {
     popup_view_ = view;
@@ skipping 20 matching lines @@
   DCHECK(popup_view_);
 
   // TODO(shess): UpdatePopupAppearance() is called frequently, so it
   // should be really cheap, but in this case we could probably make
   // things even cheaper by refactoring between the popup-placement
   // code and the matrix-population code.
   popup_view_->UpdatePopupAppearance();
 }
 
 @end