Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: content/renderer/media/rtc_video_decoder.h

Issue 1850063003: Dynamic error tracking in RTCVideoDecoder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/rtc_video_decoder.h
diff --git a/content/renderer/media/rtc_video_decoder.h b/content/renderer/media/rtc_video_decoder.h
index fedb941f257c185e9f2a5312a423805300fb6e44..7ed95bb8fb1c4a4af9979f92f3c3c178e0094e86 100644
--- a/content/renderer/media/rtc_video_decoder.h
+++ b/content/renderer/media/rtc_video_decoder.h
@@ -194,6 +194,12 @@ class CONTENT_EXPORT RTCVideoDecoder
// Clear the pending_buffers_ queue, freeing memory.
void ClearPendingBuffers();
+ // Keep track of VDA errors.
mcasas 2016/04/01 16:39:09 s/Keep/Keeps/ , from [1] "These comments should b
emircan 2016/04/05 18:02:18 Done.
+ void IncrementVDAErrorCounter();
+
+ // Reset |vda_error_counter_| after a successfull run of decode.
+ void TryResetVDAErrorCounter();
+
enum State {
UNINITIALIZED, // The decoder has not initialized.
INITIALIZED, // The decoder has initialized.
@@ -211,7 +217,10 @@ class CONTENT_EXPORT RTCVideoDecoder
media::VideoCodecProfile vda_codec_profile_;
// Number of times that |vda_| notified of an error.
- uint32_t num_vda_errors_;
+ uint32_t vda_error_counter_;
+
+ // Number of decode completed consecutively since the last vda error.
+ uint32_t num_consecutive_vda_success_since_error_;
// The video codec type, as reported by WebRTC.
const webrtc::VideoCodecType video_codec_type_;
« no previous file with comments | « no previous file | content/renderer/media/rtc_video_decoder.cc » ('j') | content/renderer/media/rtc_video_decoder.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698