Dynamic error tracking in RTCVideoDecoder

content/renderer/media/rtc_video_decoder.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_MEDIA_RTC_VIDEO_DECODER_H_
 #define CONTENT_RENDERER_MEDIA_RTC_VIDEO_DECODER_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 176 matching lines @@
   void DCheckGpuVideoAcceleratorFactoriesTaskRunnerIsCurrent() const;
 
   // Query factories_ whether |profile| is supported and return true is so,
   // false otherwise. If true, also set resolution limits for |profile|
   // in min/max_resolution_.
   bool IsProfileSupported(media::VideoCodecProfile profile);
 
   // Clear the pending_buffers_ queue, freeing memory.
   void ClearPendingBuffers();
 
+  // Keep track of VDA errors.

[mcasas, 2016/04/01 16:39:09]

s/Keep/Keeps/ ,  from [1]
"These comments should be descriptive ("Opens the file") 
rather than imperative ("Open the file"); the comment 
describes the function, it does not tell the function what to do."

Same elsewhere.

[1] https://google.github.io/styleguide/cppguide.html#Function_Comments

[emircan, 2016/04/05 18:02:18]

Done.

+  void IncrementVDAErrorCounter();
+
+  // Reset |vda_error_counter_| after a successfull run of decode.
+  void TryResetVDAErrorCounter();
+
   enum State {
     UNINITIALIZED,  // The decoder has not initialized.
     INITIALIZED,    // The decoder has initialized.
     RESETTING,      // The decoder is being reset.
     DECODE_ERROR,   // Decoding error happened.
   };
 
   static const int32_t ID_LAST;     // maximum bitstream buffer id
   static const int32_t ID_HALF;     // half of the maximum bitstream buffer id
   static const int32_t ID_INVALID;  // indicates Reset or Release never occurred
 
   // The hardware video decoder.
   scoped_ptr<media::VideoDecodeAccelerator> vda_;
 
   media::VideoCodecProfile vda_codec_profile_;
 
   // Number of times that |vda_| notified of an error.
-  uint32_t num_vda_errors_;
+  uint32_t vda_error_counter_;
+
+  // Number of decode completed consecutively since the last vda error.
+  uint32_t num_consecutive_vda_success_since_error_;
 
   // The video codec type, as reported by WebRTC.
   const webrtc::VideoCodecType video_codec_type_;
 
   // The size of the incoming video frames.
   gfx::Size frame_size_;
 
   media::GpuVideoAcceleratorFactories* const factories_;
 
   // The texture target used for decoded pictures.
@@ skipping 14 matching lines @@
   // to us via ReusePictureBuffer.
   typedef std::map<int32_t /* picture_buffer_id */, uint32_t /* texture_id */>
       PictureBufferTextureMap;
   PictureBufferTextureMap picture_buffers_at_display_;
 
   // The id that will be given to the next picture buffer.
   int32_t next_picture_buffer_id_;
 
   // Protects |state_|, |decode_complete_callback_| , |num_shm_buffers_|,
   // |available_shm_segments_|, |pending_buffers_|, |decode_buffers_|,
   // |next_bitstream_buffer_id_| and |reset_bitstream_buffer_id_|.

[mcasas, 2016/04/01 16:39:09]

Now |lock_| also protects |vda_error_counter_| and
|num_consecutive_success_since_error_| correct?

[emircan, 2016/04/05 18:02:18]

Yes. Done.

   base::Lock lock_;
 
   // The state of RTCVideoDecoder. Guarded by |lock_|.
   State state_;
 
   // Guarded by |lock_|.
   webrtc::DecodedImageCallback* decode_complete_callback_;
 
   // Total number of allocated SHM buffers. Guarded by |lock_|.
   size_t num_shm_buffers_;
@@ skipping 26 matching lines @@
   // Must be destroyed, or invalidated, on |vda_loop_proxy_|
   // NOTE: Weak pointers must be invalidated before all other member variables.
   base::WeakPtrFactory<RTCVideoDecoder> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RTCVideoDecoder);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_MEDIA_RTC_VIDEO_DECODER_H_