Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2529)

Unified Diff: net/http/http_stream_factory_impl_unittest.cc

Issue 1850043002: Check whether to enable token binding in preconnect.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove ssl_config args from PreconnectStreams and remove privacy mode/token binding duplicate logic Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_stream_factory_impl_unittest.cc
diff --git a/net/http/http_stream_factory_impl_unittest.cc b/net/http/http_stream_factory_impl_unittest.cc
index f95ea511fa3a17985f9b717ea06375915ddd33c2..99cfa22f70b5742f70c16c6c18b413aa2458bbed 100644
--- a/net/http/http_stream_factory_impl_unittest.cc
+++ b/net/http/http_stream_factory_impl_unittest.cc
@@ -341,16 +341,13 @@ void PreconnectHelperForURL(int num_streams,
MockHttpStreamFactoryImplForPreconnect* mock_factory =
new MockHttpStreamFactoryImplForPreconnect(session);
peer.SetHttpStreamFactory(scoped_ptr<HttpStreamFactory>(mock_factory));
- SSLConfig ssl_config;
- session->ssl_config_service()->GetSSLConfig(&ssl_config);
HttpRequestInfo request;
request.method = "GET";
request.url = url;
request.load_flags = 0;
- session->http_stream_factory()->PreconnectStreams(num_streams, request,
- ssl_config, ssl_config);
+ session->http_stream_factory()->PreconnectStreams(num_streams, request);
mock_factory->WaitForPreconnects();
}
@@ -954,10 +951,7 @@ TEST_P(HttpStreamFactoryTest, QuicDisablePreConnectIfZeroRtt) {
request.url = url;
request.load_flags = 0;
- SSLConfig ssl_config;
- session->ssl_config_service()->GetSSLConfig(&ssl_config);
- session->http_stream_factory()->PreconnectStreams(num_streams, request,
- ssl_config, ssl_config);
+ session->http_stream_factory()->PreconnectStreams(num_streams, request);
EXPECT_EQ(-1, transport_conn_pool->last_num_streams());
}
}

Powered by Google App Engine
This is Rietveld 408576698