Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: net/http/http_stream_factory_impl.cc

Issue 1850043002: Check whether to enable token binding in preconnect.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove ssl_config args from PreconnectStreams and remove privacy mode/token binding duplicate logic Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_stream_factory_impl.cc
diff --git a/net/http/http_stream_factory_impl.cc b/net/http/http_stream_factory_impl.cc
index d160c317468afb4e434d2b64dc23791d5402d682..04906e374d8eb49f779768e6d9756e839e528f39 100644
--- a/net/http/http_stream_factory_impl.cc
+++ b/net/http/http_stream_factory_impl.cc
@@ -140,9 +140,12 @@ HttpStreamRequest* HttpStreamFactoryImpl::RequestStreamInternal(
void HttpStreamFactoryImpl::PreconnectStreams(
int num_streams,
- const HttpRequestInfo& request_info,
- const SSLConfig& server_ssl_config,
- const SSLConfig& proxy_ssl_config) {
+ const HttpRequestInfo& request_info) {
+ SSLConfig ssl_config;
+ session_->GetSSLConfig(request_info, &ssl_config);
+ // All preconnects should perform EV certificate verification.
+ ssl_config.verify_ev_cert = true;
+
DCHECK(!for_websockets_);
AlternativeService alternative_service = GetAlternativeServiceFor(
request_info, nullptr, HttpStreamRequest::HTTP_STREAM);
@@ -163,9 +166,9 @@ void HttpStreamFactoryImpl::PreconnectStreams(
// priority currently makes sense for preconnects. The priority for
// preconnects is currently ignored (see RequestSocketsForPool()), but could
// be used at some point for proxy resolution or something.
- Job* job = new Job(this, session_, request_info, IDLE, server_ssl_config,
- proxy_ssl_config, server, origin_url, alternative_service,
- session_->net_log());
+ Job* job =
+ new Job(this, session_, request_info, IDLE, ssl_config, ssl_config,
+ server, origin_url, alternative_service, session_->net_log());
preconnect_job_set_.insert(job);
job->Preconnect(num_streams);
}

Powered by Google App Engine
This is Rietveld 408576698