Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Unified Diff: net/http/http_network_transaction_unittest.cc

Issue 1850043002: Check whether to enable token binding in preconnect.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: HttpNetworkSession::GetSSLConfig populates both server and proxy configs Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_network_transaction.cc ('k') | net/http/http_stream_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_transaction_unittest.cc
diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc
index 7aa07dba281118200426d25b389d46fb1955bbb3..04b54190e3b7258772ce91f662c650e703631b38 100644
--- a/net/http/http_network_transaction_unittest.cc
+++ b/net/http/http_network_transaction_unittest.cc
@@ -1495,12 +1495,7 @@ void HttpNetworkTransactionTest::PreconnectErrorResendRequestTest(
session_deps_.socket_factory->AddSocketDataProvider(&data2);
// Preconnect a socket.
- SSLConfig ssl_config;
- session->ssl_config_service()->GetSSLConfig(&ssl_config);
- session->GetAlpnProtos(&ssl_config.alpn_protos);
- session->GetNpnProtos(&ssl_config.npn_protos);
- session->http_stream_factory()->PreconnectStreams(1, request, ssl_config,
- ssl_config);
+ session->http_stream_factory()->PreconnectStreams(1, request);
// Wait for the preconnect to complete.
// TODO(davidben): Some way to wait for an idle socket count might be handy.
base::RunLoop().RunUntilIdle();
@@ -14682,9 +14677,7 @@ class FakeStreamFactory : public HttpStreamFactory {
}
void PreconnectStreams(int num_streams,
- const HttpRequestInfo& info,
- const SSLConfig& server_ssl_config,
- const SSLConfig& proxy_ssl_config) override {
+ const HttpRequestInfo& info) override {
ADD_FAILURE();
}
@@ -15094,10 +15087,7 @@ TEST_P(HttpNetworkTransactionTest, CloseSSLSocketOnIdleForHttpRequest2) {
// Preconnect an SSL socket. A preconnect is needed because connect jobs are
// cancelled when a normal transaction is cancelled.
HttpStreamFactory* http_stream_factory = session->http_stream_factory();
- SSLConfig ssl_config;
- session->ssl_config_service()->GetSSLConfig(&ssl_config);
- http_stream_factory->PreconnectStreams(1, ssl_request, ssl_config,
- ssl_config);
+ http_stream_factory->PreconnectStreams(1, ssl_request);
EXPECT_EQ(0, GetIdleSocketCountInSSLSocketPool(session.get()));
// Start the HTTP request. Pool should stall.
@@ -15924,6 +15914,10 @@ TEST_P(HttpNetworkTransactionTest, EnableNPN) {
std::unique_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
HttpNetworkTransaction trans(DEFAULT_PRIORITY, session.get());
+ HttpRequestInfo request;
+ TestCompletionCallback callback;
+ EXPECT_EQ(ERR_IO_PENDING,
+ trans.Start(&request, callback.callback(), BoundNetLog()));
EXPECT_THAT(trans.server_ssl_config_.alpn_protos,
testing::ElementsAre(kProtoHTTP2, kProtoSPDY31, kProtoHTTP11));
@@ -15936,6 +15930,10 @@ TEST_P(HttpNetworkTransactionTest, DisableNPN) {
std::unique_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
HttpNetworkTransaction trans(DEFAULT_PRIORITY, session.get());
+ HttpRequestInfo request;
+ TestCompletionCallback callback;
+ EXPECT_EQ(ERR_IO_PENDING,
+ trans.Start(&request, callback.callback(), BoundNetLog()));
EXPECT_THAT(trans.server_ssl_config_.alpn_protos,
testing::ElementsAre(kProtoHTTP2, kProtoSPDY31, kProtoHTTP11));
« no previous file with comments | « net/http/http_network_transaction.cc ('k') | net/http/http_stream_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698