Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: net/http/http_network_transaction.cc

Issue 1850043002: Check whether to enable token binding in preconnect.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: HttpNetworkSession::GetSSLConfig populates both server and proxy configs Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_network_session.cc ('k') | net/http/http_network_transaction_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_transaction.cc
diff --git a/net/http/http_network_transaction.cc b/net/http/http_network_transaction.cc
index 9917c69f04b81d4326bccfbca4bce66f6f9f7b8a..0820cd6a02fc0dd2ca13420035715641b26fe5ad 100644
--- a/net/http/http_network_transaction.cc
+++ b/net/http/http_network_transaction.cc
@@ -121,10 +121,6 @@ HttpNetworkTransaction::HttpNetworkTransaction(RequestPriority priority,
establishing_tunnel_(false),
websocket_handshake_stream_base_create_helper_(NULL),
net_error_details_() {
- session->ssl_config_service()->GetSSLConfig(&server_ssl_config_);
- session->GetAlpnProtos(&server_ssl_config_.alpn_protos);
- session->GetNpnProtos(&server_ssl_config_.npn_protos);
- proxy_ssl_config_ = server_ssl_config_;
}
HttpNetworkTransaction::~HttpNetworkTransaction() {
@@ -154,6 +150,9 @@ int HttpNetworkTransaction::Start(const HttpRequestInfo* request_info,
net_log_ = net_log;
request_ = request_info;
+ // Now that we have an HttpRequestInfo object, update server_ssl_config_.
+ session_->GetSSLConfig(*request_, &server_ssl_config_, &proxy_ssl_config_);
+
if (request_->load_flags & LOAD_DISABLE_CERT_REVOCATION_CHECKING) {
server_ssl_config_.rev_checking_enabled = false;
proxy_ssl_config_.rev_checking_enabled = false;
@@ -162,14 +161,6 @@ int HttpNetworkTransaction::Start(const HttpRequestInfo* request_info,
if (request_->load_flags & LOAD_PREFETCH)
response_.unused_since_prefetch = true;
- // Channel ID is disabled if privacy mode is enabled for this request.
- if (request_->privacy_mode == PRIVACY_MODE_ENABLED) {
- server_ssl_config_.channel_id_enabled = false;
- } else if (session_->params().enable_token_binding &&
- session_->params().channel_id_service) {
- server_ssl_config_.token_binding_params.push_back(TB_PARAM_ECDSAP256);
- }
-
next_state_ = STATE_NOTIFY_BEFORE_CREATE_STREAM;
int rv = DoLoop(OK);
if (rv == ERR_IO_PENDING)
« no previous file with comments | « net/http/http_network_session.cc ('k') | net/http/http_network_transaction_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698