Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1470)

Unified Diff: content/public/browser/web_contents.h

Issue 18500005: Fix SessionStorage confusion between RenderViewHostImpl and NavigationController. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: code review Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents.h
diff --git a/content/public/browser/web_contents.h b/content/public/browser/web_contents.h
index 037fef842b57e2ef679b808e28e60f4949620014..47cd101154d2313e2bf8b4eef0dd40dc0ae9da50 100644
--- a/content/public/browser/web_contents.h
+++ b/content/public/browser/web_contents.h
@@ -91,8 +91,8 @@ class WebContents : public PageNavigator,
// Creates a new WebContents.
CONTENT_EXPORT static WebContents* Create(const CreateParams& params);
- // Similar to Create() above but should be used when you need to prepopulate
- // the SessionStorageNamespaceMap of the WebContents. This can happen if
+ // Similar to Create() above but should be used when you need to set the
+ // the SessionStorageNamespace of the WebContents. This can happen if
// you duplicate a WebContents, try to reconstitute it from a saved state,
// or when you create a new WebContents based on another one (eg., when
// servicing a window.open() call).
@@ -103,7 +103,7 @@ class WebContents : public PageNavigator,
// can happen if you share the object.
CONTENT_EXPORT static WebContents* CreateWithSessionStorage(
const CreateParams& params,
- const SessionStorageNamespaceMap& session_storage_namespace_map);
+ SessionStorageNamespace* session_storage_namespace);
// Adds/removes a callback called on creation of each new WebContents.
typedef base::Callback<void(WebContents*)> CreatedCallback;

Powered by Google App Engine
This is Rietveld 408576698