content/browser/web_contents/render_view_host_manager.cc - Issue 18500005: Fix SessionStorage confusion between RenderViewHostImpl and NavigationController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/render_view_host_manager.cc

Issue 18500005: Fix SessionStorage confusion between RenderViewHostImpl and NavigationController. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: code review Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/web_contents/navigation_controller_impl.cc ('K') | « content/browser/web_contents/navigation_controller_impl_unittest.cc ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/render_view_host_manager.cc

diff --git a/content/browser/web_contents/render_view_host_manager.cc b/content/browser/web_contents/render_view_host_manager.cc

index 4c93537ebe51076cf1e5b0b21ca27f8a3255c360..4201eb8f83dd7f9b9dceb68c00eea7b31f4e4d69 100644

--- a/content/browser/web_contents/render_view_host_manager.cc

+++ b/content/browser/web_contents/render_view_host_manager.cc

@@ -83,9 +83,7 @@ void RenderViewHostManager::Init(BrowserContext* browser_context,

render_view_host_ = static_cast<RenderViewHostImpl*>(

RenderViewHostFactory::Create(

site_instance, render_view_delegate_, render_widget_delegate_,

- routing_id, main_frame_routing_id, false, delegate_->

- GetControllerForRenderManager().GetSessionStorageNamespace(

- site_instance)));

+ routing_id, main_frame_routing_id, false));

awong 2013/07/22 22:35:33 Here we still need GetSessionStorageNamespace for

// Keep track of renderer processes as they start to shut down or are

// crashed/killed.

@@ -661,10 +659,11 @@ int RenderViewHostManager::CreateRenderView(

// Create a new RenderViewHost if we don't find an existing one.

new_render_view_host = static_cast<RenderViewHostImpl*>(

RenderViewHostFactory::Create(instance,

- render_view_delegate_, render_widget_delegate_, MSG_ROUTING_NONE,

- MSG_ROUTING_NONE, swapped_out, delegate_->

- GetControllerForRenderManager().GetSessionStorageNamespace(

- instance)));

+ render_view_delegate_,

+ render_widget_delegate_,

+ MSG_ROUTING_NONE,

+ swapped_out));

// If the new RVH is swapped out already, store it. Otherwise prevent the

// process from exiting while we're trying to navigate in it.