Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 18500005: Fix SessionStorage confusion between RenderViewHostImpl and NavigationController. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: code review Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_view_host_impl.cc
diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc
index a7fa73ed88afac2598205cac99affe472e4c98a2..718cdc96998d4ec06c6ea44a1096694bb30cabfa 100644
--- a/content/browser/renderer_host/render_view_host_impl.cc
+++ b/content/browser/renderer_host/render_view_host_impl.cc
@@ -154,8 +154,7 @@ RenderViewHostImpl::RenderViewHostImpl(
RenderWidgetHostDelegate* widget_delegate,
int routing_id,
int main_frame_routing_id,
- bool swapped_out,
- SessionStorageNamespace* session_storage)
+ bool swapped_out)
: RenderWidgetHostImpl(widget_delegate, instance->GetProcess(), routing_id),
delegate_(delegate),
instance_(static_cast<SiteInstanceImpl*>(instance)),
@@ -174,10 +173,7 @@ RenderViewHostImpl::RenderViewHostImpl(
unload_ack_is_for_cross_site_transition_(false),
are_javascript_messages_suppressed_(false),
sudden_termination_allowed_(false),
- session_storage_namespace_(
- static_cast<SessionStorageNamespaceImpl*>(session_storage)),
render_view_termination_status_(base::TERMINATION_STATUS_STILL_RUNNING) {
- DCHECK(session_storage_namespace_.get());
DCHECK(instance_.get());
CHECK(delegate_); // http://crbug.com/82827
@@ -260,7 +256,8 @@ bool RenderViewHostImpl::CreateRenderView(
params.view_id = GetRoutingID();
params.main_frame_routing_id = main_render_frame_host_->routing_id();
params.surface_id = surface_id();
- params.session_storage_namespace_id = session_storage_namespace_->id();
+ params.session_storage_namespace_id =
+ delegate_->GetSessionStorageNamespace()->id();
params.frame_name = frame_name;
// Ensure the RenderView sets its opener correctly.
params.opener_route_id = opener_route_id;

Powered by Google App Engine
This is Rietveld 408576698