Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Unified Diff: content/browser/renderer_host/test_render_view_host.cc

Issue 18500005: Fix SessionStorage confusion between RenderViewHostImpl and NavigationController. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: code review Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/test_render_view_host.cc
diff --git a/content/browser/renderer_host/test_render_view_host.cc b/content/browser/renderer_host/test_render_view_host.cc
index 31507a999451fc40aec1f3d47f282bf0af2f86dc..ddc8ffab0e94877428e001e4dc0497fbd0c8f8f7 100644
--- a/content/browser/renderer_host/test_render_view_host.cc
+++ b/content/browser/renderer_host/test_render_view_host.cc
@@ -24,17 +24,6 @@
namespace content {
namespace {
-// Normally this is done by the NavigationController, but we'll fake it out
-// here for testing.
-SessionStorageNamespaceImpl* CreateSessionStorageNamespace(
- SiteInstance* instance) {
- RenderProcessHost* process_host = instance->GetProcess();
- DOMStorageContext* dom_storage_context =
- BrowserContext::GetStoragePartition(process_host->GetBrowserContext(),
- instance)->GetDOMStorageContext();
- return new SessionStorageNamespaceImpl(
- static_cast<DOMStorageContextImpl*>(dom_storage_context));
-}
const int64 kFrameId = 13UL;
@@ -257,8 +246,7 @@ TestRenderViewHost::TestRenderViewHost(
widget_delegate,
routing_id,
main_frame_routing_id,
- swapped_out,
- CreateSessionStorageNamespace(instance)),
+ swapped_out),
render_view_created_(false),
delete_counter_(NULL),
simulate_fetch_via_proxy_(false),

Powered by Google App Engine
This is Rietveld 408576698