Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 184993010: Add support for previewComment in Typedef (Closed)

Created:
6 years, 9 months ago by kevmoo
Modified:
6 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dartdoc-viewer.git@master
Visibility:
Public.

Description

Add support for previewComment in Typedef finalized a few properties better naming of nothing method R=efortuna@google.com Committed: https://github.com/dart-lang/dartdoc-viewer/commit/c2ab582

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -21 lines) Patch
M client/lib/item.dart View 10 chunks +24 lines, -21 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kevmoo
See sister CL here https://codereview.chromium.org/183333003/
6 years, 9 months ago (2014-03-05 00:42:49 UTC) #1
Emily Fortuna
lgtm
6 years, 9 months ago (2014-03-05 01:28:30 UTC) #2
kevmoo
6 years, 9 months ago (2014-03-05 01:30:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as rc2ab582 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698