Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: net/cert/internal/parse_ocsp_unittest.cc

Issue 1849773002: Adding OCSP Verification Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing includes. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/cert/internal/parse_ocsp.cc ('K') | « net/cert/internal/parse_ocsp.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/internal/parse_ocsp_unittest.cc
diff --git a/net/cert/internal/parse_ocsp_unittest.cc b/net/cert/internal/parse_ocsp_unittest.cc
index 12657e626952b1fb2b38ef93c0f72a6e06e93d75..19a3fe158da476d2d413a1ba04fe8a2607e49fdc 100644
--- a/net/cert/internal/parse_ocsp_unittest.cc
+++ b/net/cert/internal/parse_ocsp_unittest.cc
@@ -62,6 +62,8 @@ OCSPFailure ParseOCSP(const std::string& file_name) {
return OCSP_NOT_SUCCESSFUL;
if (!ParseOCSPResponseData(parsed_ocsp.data, &parsed_ocsp_data))
return PARSE_OCSP_DATA;
+ if (!VerifyOCSPResponse(parsed_ocsp, issuer))
+ return VERIFY_OCSP;
OCSPCertStatus status;
@@ -103,7 +105,7 @@ TEST(ParseOCSPTest, OCSPInvalidOCSPOid) {
}
TEST(ParseOCSPTest, OCSPBadSignature) {
- ASSERT_EQ(OCSP_SUCCESS, ParseOCSP("bad_signature.pem"));
+ ASSERT_EQ(VERIFY_OCSP, ParseOCSP("bad_signature.pem"));
}
TEST(ParseOCSPTest, OCSPDirectSignature) {
@@ -115,11 +117,11 @@ TEST(ParseOCSPTest, OCSPIndirectSignature) {
}
TEST(ParseOCSPTest, OCSPMissingIndirectSignature) {
- ASSERT_EQ(OCSP_SUCCESS, ParseOCSP("ocsp_sign_indirect_missing.pem"));
+ ASSERT_EQ(VERIFY_OCSP, ParseOCSP("ocsp_sign_indirect_missing.pem"));
}
TEST(ParseOCSPTest, OCSPInvalidSignature) {
- ASSERT_EQ(OCSP_SUCCESS, ParseOCSP("ocsp_sign_bad_indirect.pem"));
+ ASSERT_EQ(VERIFY_OCSP, ParseOCSP("ocsp_sign_bad_indirect.pem"));
}
TEST(ParseOCSPTest, OCSPExtraCerts) {
« net/cert/internal/parse_ocsp.cc ('K') | « net/cert/internal/parse_ocsp.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698