Adding OCSP Verification

net/cert/internal/parse_ocsp_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/internal/parse_ocsp.h"
 
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "net/base/test_data_directory.h"
 #include "net/cert/internal/test_helpers.h"
@@ skipping 44 matching lines @@
   if (!ParseCertificate(cert_input, &cert))
     return PARSE_CERT;
   OCSPResponse parsed_ocsp;
   OCSPResponseData parsed_ocsp_data;
   if (!ParseOCSPResponse(ocsp_input, &parsed_ocsp))
     return PARSE_OCSP;
   if (parsed_ocsp.status != OCSPResponse::ResponseStatus::SUCCESSFUL)
     return OCSP_NOT_SUCCESSFUL;
   if (!ParseOCSPResponseData(parsed_ocsp.data, &parsed_ocsp_data))
     return PARSE_OCSP_DATA;
+  if (!VerifyOCSPResponse(parsed_ocsp, issuer))
+    return VERIFY_OCSP;
 
   OCSPCertStatus status;
 
   if (!GetOCSPCertStatus(parsed_ocsp_data, issuer, cert, &status))
     return PARSE_OCSP_SINGLE_RESPONSE;
 
   switch (status.status) {
     case OCSPCertStatus::Status::GOOD:
       return OCSP_SUCCESS;
     case OCSPCertStatus::Status::REVOKED:
@@ skipping 21 matching lines @@
 
 TEST(ParseOCSPTest, OCSPBadStatus) {
   ASSERT_EQ(PARSE_OCSP, ParseOCSP("bad_status.pem"));
 }
 
 TEST(ParseOCSPTest, OCSPInvalidOCSPOid) {
   ASSERT_EQ(PARSE_OCSP, ParseOCSP("bad_ocsp_type.pem"));
 }
 
 TEST(ParseOCSPTest, OCSPBadSignature) {
-  ASSERT_EQ(OCSP_SUCCESS, ParseOCSP("bad_signature.pem"));
+  ASSERT_EQ(VERIFY_OCSP, ParseOCSP("bad_signature.pem"));
 }
 
 TEST(ParseOCSPTest, OCSPDirectSignature) {
   ASSERT_EQ(OCSP_SUCCESS, ParseOCSP("ocsp_sign_direct.pem"));
 }
 
 TEST(ParseOCSPTest, OCSPIndirectSignature) {
   ASSERT_EQ(OCSP_SUCCESS, ParseOCSP("ocsp_sign_indirect.pem"));
 }
 
 TEST(ParseOCSPTest, OCSPMissingIndirectSignature) {
-  ASSERT_EQ(OCSP_SUCCESS, ParseOCSP("ocsp_sign_indirect_missing.pem"));
+  ASSERT_EQ(VERIFY_OCSP, ParseOCSP("ocsp_sign_indirect_missing.pem"));
 }
 
 TEST(ParseOCSPTest, OCSPInvalidSignature) {
-  ASSERT_EQ(OCSP_SUCCESS, ParseOCSP("ocsp_sign_bad_indirect.pem"));
+  ASSERT_EQ(VERIFY_OCSP, ParseOCSP("ocsp_sign_bad_indirect.pem"));
 }
 
 TEST(ParseOCSPTest, OCSPExtraCerts) {
   ASSERT_EQ(OCSP_SUCCESS, ParseOCSP("ocsp_extra_certs.pem"));
 }
 
 TEST(ParseOCSPTest, OCSPIncludesVersion) {
   ASSERT_EQ(OCSP_SUCCESS, ParseOCSP("has_version.pem"));
 }
 
@@ skipping 35 matching lines @@
 
 TEST(ParseOCSPTest, OCSPOCSPSingleExtension) {
   ASSERT_EQ(OCSP_SUCCESS, ParseOCSP("has_single_extension.pem"));
 }
 
 TEST(ParseOCSPTest, OCSPMissingResponse) {
   ASSERT_EQ(PARSE_OCSP_SINGLE_RESPONSE, ParseOCSP("missing_response.pem"));
 }
 
 }  // namespace net