Use sk_sp-based shader setting APIs

Use sk_sp-based shader setting APIs

Favor Skia's smart pointer based interface over raw pointers.
Part 2 after https://codereview.chromium.org/1829303002;
removes SK_SUPPORT_LEGACY_CREATESHADER_PTR.

BUG=skia:5077, 597620
R=fmalita@chromium.org
TBR=danakj@chromium.org

Committed: https://crrev.com/a7bbd0df36e31d2b8bcb7e1176c8f1fb624155ab
Cr-Commit-Position: refs/heads/master@{#384426}
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

[tomhudson, 2016-03-31 15:01:41]

The CQ bit was checked by tomhudson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 15:01:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1849763002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1849763002/1

[tomhudson, 2016-03-31 15:23:39]

This is simpler than we feared, and if I don't do this first then the Xfermodes
cleanup gets nasty (because we start having to deal with temporary mixed
versions for all of the cross product of functions-that-take-shaders and
functions-that-take-xfermodes).

[f(malita), 2016-03-31 15:38:04]

lgtm

https://codereview.chromium.org/1849763002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/filters/FETurbulence.h (right):

https://codereview.chromium.org/1849763002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/filters/FETurbulence.h:68:
sk_sp<SkShader> createShader();
While we touch this: looks like it should be a const method.

[tomhudson, 2016-03-31 16:54:37]

The CQ bit was checked by tomhudson@google.com

[tomhudson, 2016-03-31 16:54:37]

The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/1849763002/#ps20001
(title: "Review constness + rebase")

[commit-bot: I haz the power, 2016-03-31 16:54:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1849763002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1849763002/20001

[danakj, 2016-03-31 19:50:02]

https://codereview.chromium.org/1849763002/diff/20001/ui/gfx/canvas.cc
File ui/gfx/canvas.cc (right):

https://codereview.chromium.org/1849763002/diff/20001/ui/gfx/canvas.cc#newcod...
ui/gfx/canvas.cc:503: paint->setShader(CreateImageRepShader(image_rep,
SkShader::kRepeat_TileMode,
How does it work? CreateIRShader returns a skia::RefPtr.

[f(malita), 2016-03-31 19:51:44]

https://codereview.chromium.org/1849763002/diff/20001/ui/gfx/canvas.cc
File ui/gfx/canvas.cc (right):

https://codereview.chromium.org/1849763002/diff/20001/ui/gfx/canvas.cc#newcod...
ui/gfx/canvas.cc:503: paint->setShader(CreateImageRepShader(image_rep,
SkShader::kRepeat_TileMode,
On 2016/03/31 19:50:02, danakj wrote:
> How does it work? CreateIRShader returns a skia::RefPtr.

I had the exact same headscratch, but sync your tree - it now returns sk_sp :)

[tomhudson, 2016-03-31 19:51:59]

On 2016/03/31 19:50:02, danakj wrote:
> https://codereview.chromium.org/1849763002/diff/20001/ui/gfx/canvas.cc
> File ui/gfx/canvas.cc (right):
> 
>
https://codereview.chromium.org/1849763002/diff/20001/ui/gfx/canvas.cc#newcod...
> ui/gfx/canvas.cc:503: paint->setShader(CreateImageRepShader(image_rep,
> SkShader::kRepeat_TileMode,
> How does it work? CreateIRShader returns a skia::RefPtr.

Since 2b45cf96a (a few hours ago) it returns sk_sp<SkShader>.

[danakj, 2016-03-31 19:53:22]

https://codereview.chromium.org/1849763002/diff/20001/ui/gfx/canvas.cc
File ui/gfx/canvas.cc (right):

https://codereview.chromium.org/1849763002/diff/20001/ui/gfx/canvas.cc#newcod...
ui/gfx/canvas.cc:503: paint->setShader(CreateImageRepShader(image_rep,
SkShader::kRepeat_TileMode,
On 2016/03/31 19:51:44, f(malita) wrote:
> On 2016/03/31 19:50:02, danakj wrote:
> > How does it work? CreateIRShader returns a skia::RefPtr.
> 
> I had the exact same headscratch, but sync your tree - it now returns sk_sp :)

Oh ok, codesearch isn't updated yet. LGTM

[commit-bot: I haz the power, 2016-03-31 20:57:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 20:57:46]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tomhudson, 2016-03-31 21:19:27]

The CQ bit was checked by tomhudson@google.com

[commit-bot: I haz the power, 2016-03-31 21:19:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1849763002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1849763002/20001

[commit-bot: I haz the power, 2016-03-31 22:58:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-31 22:59:10]

Description was changed from

==========
Use sk_sp-based shader setting APIs

Favor Skia's smart pointer based interface over raw pointers.
Part 2 after https://codereview.chromium.org/1829303002;
removes SK_SUPPORT_LEGACY_CREATESHADER_PTR.

BUG=skia:5077,597620
R=fmalita@chromium.org
TBR=danakj@chromium.org
==========

to

==========
Use sk_sp-based shader setting APIs

Favor Skia's smart pointer based interface over raw pointers.
Part 2 after https://codereview.chromium.org/1829303002;
removes SK_SUPPORT_LEGACY_CREATESHADER_PTR.

BUG=skia:5077,597620
R=fmalita@chromium.org
TBR=danakj@chromium.org

Committed: https://crrev.com/a7bbd0df36e31d2b8bcb7e1176c8f1fb624155ab
Cr-Commit-Position: refs/heads/master@{#384426}
==========

[commit-bot: I haz the power, 2016-03-31 22:59:11]

Patchset 2 (id:??) landed as
https://crrev.com/a7bbd0df36e31d2b8bcb7e1176c8f1fb624155ab
Cr-Commit-Position: refs/heads/master@{#384426}

[tomhudson, 2016-04-01 13:39:29]

Description was changed from

==========
Use sk_sp-based shader setting APIs

Favor Skia's smart pointer based interface over raw pointers.
Part 2 after https://codereview.chromium.org/1829303002;
removes SK_SUPPORT_LEGACY_CREATESHADER_PTR.

BUG=skia:5077,597620
R=fmalita@chromium.org
TBR=danakj@chromium.org

Committed: https://crrev.com/a7bbd0df36e31d2b8bcb7e1176c8f1fb624155ab
Cr-Commit-Position: refs/heads/master@{#384426}
==========

to

==========
Use sk_sp-based shader setting APIs

Favor Skia's smart pointer based interface over raw pointers.
Part 2 after https://codereview.chromium.org/1829303002;
removes SK_SUPPORT_LEGACY_CREATESHADER_PTR.

BUG=skia:5077,597620
R=fmalita@chromium.org
TBR=danakj@chromium.org

Committed: https://crrev.com/a7bbd0df36e31d2b8bcb7e1176c8f1fb624155ab
Cr-Commit-Position: refs/heads/master@{#384426}
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[tomhudson, 2016-04-01 13:39:50]

Patchset #3 (id:40001) has been deleted