Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7527)

Unified Diff: components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java

Issue 1849753002: [Cronet] Separate Cronet implementation and API by package name. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sync Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java
diff --git a/components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java b/components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java
index 9a944547c1448bf71879f6656b45888f4c906589..f12904fc8b44e3bed7d4fc5820a9372d57b679ff 100644
--- a/components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java
+++ b/components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java
@@ -63,8 +63,9 @@ final class JavaCronetEngine extends CronetEngine {
}
@Override
- BidirectionalStream createBidirectionalStream(String url, BidirectionalStream.Callback callback,
- Executor executor, String httpMethod, List<Map.Entry<String, String>> requestHeaders,
+ public BidirectionalStream createBidirectionalStream(String url,
kapishnikov 2016/07/22 05:54:13 Should it be hidden?
pauljensen 2016/07/22 11:10:33 This class is package-private so it's hidden from
+ BidirectionalStream.Callback callback, Executor executor, String httpMethod,
+ List<Map.Entry<String, String>> requestHeaders,
@BidirectionalStream.Builder.StreamPriority int priority, boolean disableAutoFlush,
boolean delayRequestHeadersUntilFirstFlush) {
throw new UnsupportedOperationException(
@@ -72,13 +73,13 @@ final class JavaCronetEngine extends CronetEngine {
}
@Override
- boolean isEnabled() {
+ public boolean isEnabled() {
return true;
}
@Override
public String getVersionString() {
- return "CronetHttpURLConnection/" + Version.getVersion();
+ return "CronetHttpURLConnection/" + ApiVersion.getVersion();
}
@Override
@@ -109,7 +110,7 @@ final class JavaCronetEngine extends CronetEngine {
public void enableNetworkQualityEstimator(Executor executor) {}
@Override
- void configureNetworkQualityEstimatorForTesting(
+ public void configureNetworkQualityEstimatorForTesting(
boolean useLocalHostRequests, boolean useSmallerResponses) {}
@Override

Powered by Google App Engine
This is Rietveld 408576698