[Cronet] Separate Cronet implementation and API by package name.

components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net;
 
 import static android.os.Process.THREAD_PRIORITY_BACKGROUND;
 import static android.os.Process.THREAD_PRIORITY_MORE_FAVORABLE;
 
 import java.io.IOException;
@@ skipping 45 matching lines @@
     }
 
     @Override
     public UrlRequest createRequest(String url, UrlRequest.Callback callback, Executor executor,
             int priority, Collection<Object> connectionAnnotations, boolean disableCache,
             boolean disableConnectionMigration) {
         return new JavaUrlRequest(callback, mExecutorService, executor, url, mUserAgent);
     }
 
     @Override
-    BidirectionalStream createBidirectionalStream(String url, BidirectionalStream.Callback callback,
-            Executor executor, String httpMethod, List<Map.Entry<String, String>> requestHeaders,
+    public BidirectionalStream createBidirectionalStream(String url,

[kapishnikov, 2016/07/22 05:54:13]

Should it be hidden?

[pauljensen, 2016/07/22 11:10:33]

This class is package-private so it's hidden from javadocs.

+            BidirectionalStream.Callback callback, Executor executor, String httpMethod,
+            List<Map.Entry<String, String>> requestHeaders,
             @BidirectionalStream.Builder.StreamPriority int priority, boolean disableAutoFlush,
             boolean delayRequestHeadersUntilFirstFlush) {
         throw new UnsupportedOperationException(
                 "Can't create a bidi stream - httpurlconnection doesn't have those APIs");
     }
 
     @Override
-    boolean isEnabled() {
+    public boolean isEnabled() {
         return true;
     }
 
     @Override
     public String getVersionString() {
-        return "CronetHttpURLConnection/" + Version.getVersion();
+        return "CronetHttpURLConnection/" + ApiVersion.getVersion();
     }
 
     @Override
     public void shutdown() {
         mExecutorService.shutdown();
     }
 
     @Override
     public void startNetLogToFile(String fileName, boolean logAll) {}
 
@@ skipping 10 matching lines @@
         return new byte[0];
     }
 
     @Override
     public void setRequestFinishedListenerExecutor(Executor executor) {}
 
     @Override
     public void enableNetworkQualityEstimator(Executor executor) {}
 
     @Override
-    void configureNetworkQualityEstimatorForTesting(
+    public void configureNetworkQualityEstimatorForTesting(
             boolean useLocalHostRequests, boolean useSmallerResponses) {}
 
     @Override
     public void addRttListener(NetworkQualityRttListener listener) {}
 
     @Override
     public void removeRttListener(NetworkQualityRttListener listener) {}
 
     @Override
     public void addThroughputListener(NetworkQualityThroughputListener listener) {}
@@ skipping 22 matching lines @@
         // Returning null causes this factory to pass though, which ends up using the platform's
         // implementation.
         return new URLStreamHandlerFactory() {
             @Override
             public URLStreamHandler createURLStreamHandler(String protocol) {
                 return null;
             }
         };
     }
 }