Issue 184973007: Fix CTM scaling and clipping of SkRectShaderImageFilter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 184973007: Fix CTM scaling and clipping of SkRectShaderImageFilter. (Closed)

Created:
6 years, 9 months ago by Stephen White

Modified:
6 years, 9 months ago

Reviewers:
sugoi1, sugoi

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fix CTM scaling and clipping of SkRectShaderImageFilter. Pass the CTM as part of the local matrix passed by SkRectShaderImageFilter. Teach SkPerlinNoiseShader to respect the local matrix. Embiggen imagefiltersscaled GM size to accommodate the new test cases. Note: will require rebaselines of imagefiltersscaled and imagefiltersclipped R=sugoi@chromium.org BUG=skia: Committed: https://code.google.com/p/skia/source/detail?r=13637

Patch Set 1 #

Patch Set 2 : Add test suppressions #

Patch Set 3 : Leanr ot ytpe #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -3 lines)			Patch
M	expectations/gm/ignored-tests.txt	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	gm/imagefiltersclipped.cpp	View		3 chunks	+5 lines, -0 lines	0 comments	Download
M	gm/imagefiltersscaled.cpp	View		4 chunks	+6 lines, -1 line	0 comments	Download
M	src/effects/SkPerlinNoiseShader.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/effects/SkRectShaderImageFilter.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sugoi

On 2014/02/28 23:41:54, Stephen White wrote: > sugoi@: PTAL. Thanks! LGTM

6 years, 9 months ago (2014-03-03 13:09:19 UTC) #2

Stephen White

6 years, 9 months ago (2014-03-03 14:58:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r13637 (presubmit successful).

Expand Messages | Collapse Messages