Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1094)

Unified Diff: chrome/browser/ui/views/global_error_bubble_view.cc

Issue 1849703004: Handle bubble title resizing (growth) by reworking title layout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tweaks Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/global_error_bubble_view.cc
diff --git a/chrome/browser/ui/views/global_error_bubble_view.cc b/chrome/browser/ui/views/global_error_bubble_view.cc
index 7d46d5474fae069fa312a904c099ccd7b80fbbe4..10c069177d61d04b7c79046980271be56d302f76 100644
--- a/chrome/browser/ui/views/global_error_bubble_view.cc
+++ b/chrome/browser/ui/views/global_error_bubble_view.cc
@@ -38,8 +38,6 @@ const int kMaxBubbleViewWidth = 262;
// The vertical inset of the app bubble anchor from the app menu button.
const int kAnchorVerticalInset = 5;
-const int kBubblePadding = 19;
-
// Spacing between bubble text and buttons.
const int kLabelToButtonVerticalSpacing = 14;
@@ -70,10 +68,6 @@ GlobalErrorBubbleView::GlobalErrorBubbleView(
: BubbleDelegateView(anchor_view, arrow),
browser_(browser),
error_(error) {
- // Set content margins to left-align the bubble text with the title.
- // BubbleFrameView adds enough padding below title, no top padding needed.
- set_margins(gfx::Insets(0, kBubblePadding, kBubblePadding, kBubblePadding));
msw 2016/03/31 19:18:30 Please add before/after screenshots; maybe split t
Evan Stade 2016/03/31 21:26:13 sure, done
-
// Compensate for built-in vertical padding in the anchor view's image.
set_anchor_view_insets(
gfx::Insets(kAnchorVerticalInset, 0, kAnchorVerticalInset, 0));

Powered by Google App Engine
This is Rietveld 408576698