Handle bubble title resizing (growth) by reworking title layout

chrome/browser/ui/views/global_error_bubble_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/global_error_bubble_view.h"
 
 #include <stddef.h>
 
 #include <vector>
 
@@ skipping 20 matching lines @@
 enum {
   TAG_ACCEPT_BUTTON = 1,
   TAG_CANCEL_BUTTON,
 };
 
 const int kMaxBubbleViewWidth = 262;
 
 // The vertical inset of the app bubble anchor from the app menu button.
 const int kAnchorVerticalInset = 5;
 
-const int kBubblePadding = 19;
-
 // Spacing between bubble text and buttons.
 const int kLabelToButtonVerticalSpacing = 14;
 
 }  // namespace
 
 // GlobalErrorBubbleViewBase ---------------------------------------------------
 
 // static
 GlobalErrorBubbleViewBase* GlobalErrorBubbleViewBase::ShowStandardBubbleView(
     Browser* browser,
@@ skipping 10 matching lines @@
 // GlobalErrorBubbleView -------------------------------------------------------
 
 GlobalErrorBubbleView::GlobalErrorBubbleView(
     views::View* anchor_view,
     views::BubbleBorder::Arrow arrow,
     Browser* browser,
     const base::WeakPtr<GlobalErrorWithStandardBubble>& error)
     : BubbleDelegateView(anchor_view, arrow),
       browser_(browser),
       error_(error) {
-  // Set content margins to left-align the bubble text with the title.
-  // BubbleFrameView adds enough padding below title, no top padding needed.
-  set_margins(gfx::Insets(0, kBubblePadding, kBubblePadding, kBubblePadding));

[msw, 2016/03/31 19:18:30]

Please add before/after screenshots; maybe split this out if we intend to merge
this cl back to a branch.

[Evan Stade, 2016/03/31 21:26:13]

sure, done

-
   // Compensate for built-in vertical padding in the anchor view's image.
   set_anchor_view_insets(
       gfx::Insets(kAnchorVerticalInset, 0, kAnchorVerticalInset, 0));
 
   std::vector<base::string16> message_strings(error_->GetBubbleViewMessages());
   std::vector<views::Label*> message_labels;
   for (size_t i = 0; i < message_strings.size(); ++i) {
     views::Label* message_label = new views::Label(message_strings[i]);
     message_label->SetMultiLine(true);
     message_label->SizeToFit(kMaxBubbleViewWidth);
@@ skipping 102 matching lines @@
     error_->BubbleViewDidClose(browser_);
 }
 
 bool GlobalErrorBubbleView::ShouldShowCloseButton() const {
   return error_ && error_->ShouldShowCloseButton();
 }
 
 void GlobalErrorBubbleView::CloseBubbleView() {
   GetWidget()->Close();
 }