Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 18497013: Fix a warning from Clang's -Wlogical-not-parentheses: logical not used to be applied to the left ha… (Closed)

Created:
7 years, 5 months ago by Alexander Potapenko
Modified:
7 years, 5 months ago
CC:
blink-reviews, dglazkov+blink, Nate Chapin, eae+blinkwatch, gavinp+loader_chromium.org
Visibility:
Public.

Description

Fix a warning from Clang's -Wlogical-not-parentheses: logical not used to be applied to the left hand side of the comparison (the result of parseContentTypeOptionsHeader()) TBR=jochen@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/loader/cache/CachedScript.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Alexander Potapenko
TBR This has already been approved at https://chromiumcodereview.appspot.com/18753002/, but I couldn't commit via CQ outside ...
7 years, 5 months ago (2013-07-10 15:34:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/18497013/1
7 years, 5 months ago (2013-07-10 15:34:46 UTC) #2
Alexander Potapenko
On 2013/07/10 15:34:46, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
7 years, 5 months ago (2013-07-10 15:51:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/18497013/1
7 years, 5 months ago (2013-07-11 06:04:38 UTC) #4
commit-bot: I haz the power
Failed to apply patch for Source/core/loader/cache/CachedScript.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 5 months ago (2013-07-11 06:04:41 UTC) #5
jochen (gone - plz use gerrit)
lgtm
7 years, 5 months ago (2013-07-11 06:58:27 UTC) #6
Alexander Potapenko
7 years, 5 months ago (2013-07-11 07:09:44 UTC) #7
Message was sent while issue was closed.
On 2013/07/11 06:58:27, jochen wrote:
> lgtm

Looks like Nico's land failed, but then he landed
https://codereview.chromium.org/18753002 (the very first CL)
Closing this one again.

Powered by Google App Engine
This is Rietveld 408576698