Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1849683003: Do not register invalid layout (Closed)

Created:
4 years, 8 months ago by oshima
Modified:
4 years, 8 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Do not register invalid layout This has been fixed on 51, but we need slightly different CL for 50. BUG=598361 R=stevenjb@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/1c7d95a04623a06254e0563fbd9e65e779a10eec

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M ash/display/display_layout.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/display/display_layout_store.cc View 2 chunks +4 lines, -3 lines 1 comment Download
M ash/display/display_manager_unittest.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
oshima
https://codereview.chromium.org/1849683003/diff/1/ash/display/display_layout_store.cc File ash/display/display_layout_store.cc (right): https://codereview.chromium.org/1849683003/diff/1/ash/display/display_layout_store.cc#newcode84 ash/display/display_layout_store.cc:84: CHECK_NE(layout->primary_id, gfx::Display::kInvalidDisplayID); I'm adding CHECK to have better crash ...
4 years, 8 months ago (2016-03-31 01:15:44 UTC) #2
oshima
4 years, 8 months ago (2016-04-01 21:32:48 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
1c7d95a04623a06254e0563fbd9e65e779a10eec.

Powered by Google App Engine
This is Rietveld 408576698