Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: ash/display/display_layout_store.cc

Issue 1849683003: Do not register invalid layout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2661
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/display/display_layout.cc ('k') | ash/display/display_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/display/display_layout_store.cc
diff --git a/ash/display/display_layout_store.cc b/ash/display/display_layout_store.cc
index b78bf98b36043814a921ba7e9c270b58f5fd461d..316a51175fb8bbd81c43144982ce807fe054cb01 100644
--- a/ash/display/display_layout_store.cc
+++ b/ash/display/display_layout_store.cc
@@ -68,7 +68,8 @@ void DisplayLayoutStore::RegisterLayoutForDisplayIdList(
layout->placement_list[0]->parent_display_id = list[0];
}
}
- DCHECK(DisplayLayout::Validate(list, *layout.get())) << layout->ToString();
+ if (!DisplayLayout::Validate(list, *layout.get()))
+ return;
layouts_[list] = std::move(layout);
}
@@ -79,8 +80,8 @@ const DisplayLayout& DisplayLayoutStore::GetRegisteredDisplayLayout(
const DisplayLayout* layout = iter != layouts_.end()
? iter->second.get()
: CreateDefaultDisplayLayout(list);
- DCHECK(DisplayLayout::Validate(list, *layout)) << layout->ToString();
- DCHECK_NE(layout->primary_id, gfx::Display::kInvalidDisplayID);
+ CHECK(DisplayLayout::Validate(list, *layout)) << layout->ToString();
+ CHECK_NE(layout->primary_id, gfx::Display::kInvalidDisplayID);
oshima 2016/03/31 01:15:44 I'm adding CHECK to have better crash reports when
return *layout;
}
« no previous file with comments | « ash/display/display_layout.cc ('k') | ash/display/display_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698