Issue 184963008: Pass the correct GlyphPage to glyphDataAndPageForNonCJKCharacterWithGlyphOrientation

Issue 184963008: Pass the correct GlyphPage to glyphDataAndPageForNonCJKCharacterWithGlyphOrientation (Closed)

Created:
6 years, 9 months ago by fs

Modified:
6 years, 9 months ago

Reviewers:
Stephen Chennney, dglazkov, eae

CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Pass the correct GlyphPage to glyphDataAndPageForNonCJKCharacterWithGlyphOrientation |fallbackPage| may be null, and |page| is what is manipulated. BUG=349840 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168744

Patch Set 1 #

Total comments: 4

Patch Set 2 : TC fixups. #

Patch Set 3 : ...and a newline. #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -1 line)			Patch
A	LayoutTests/svg/text/vertical-noncjk-non-existing-glyph.html	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download
A +	LayoutTests/svg/text/vertical-noncjk-non-existing-glyph-expected.txt	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/platform/fonts/Font.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Stephen Chennney

I'm happy with it except for some test cleanup. https://codereview.chromium.org/184963008/diff/1/LayoutTests/svg/text/vertical-noncjk-non-existing-glyph.html File LayoutTests/svg/text/vertical-noncjk-non-existing-glyph.html (right): https://codereview.chromium.org/184963008/diff/1/LayoutTests/svg/text/vertical-noncjk-non-existing-glyph.html#newcode1 LayoutTests/svg/text/vertical-noncjk-non-existing-glyph.html:1: ...

6 years, 9 months ago (2014-03-06 16:28:48 UTC) #2

https://codereview.chromium.org/184963008/diff/1/LayoutTests/svg/text/vertical-noncjk-non-existing-glyph.html File LayoutTests/svg/text/vertical-noncjk-non-existing-glyph.html (right): https://codereview.chromium.org/184963008/diff/1/LayoutTests/svg/text/vertical-noncjk-non-existing-glyph.html#newcode1 LayoutTests/svg/text/vertical-noncjk-non-existing-glyph.html:1: <html> On 2014/03/06 16:28:49, Stephen Chenney wrote: > Recently ...

6 years, 9 months ago (2014-03-06 17:05:19 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/184963008/20001

6 years, 9 months ago (2014-03-07 15:14:48 UTC) #7

Message was sent while issue was closed.

Change committed as 168744

Expand Messages | Collapse Messages