LayoutTests/svg/text/vertical-noncjk-non-existing-glyph.html - Issue 184963008: Pass the correct GlyphPage to glyphDataAndPageForNonCJKCharacterWithGlyphOrientation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/text/vertical-noncjk-non-existing-glyph.html

Issue 184963008: Pass the correct GlyphPage to glyphDataAndPageForNonCJKCharacterWithGlyphOrientation (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <html>
	Stephen Chennney 2014/03/06 16:28:49 Recently we try to always put DOCTYPE at the top. Recently we try to always put DOCTYPE at the top. fs 2014/03/06 17:05:19 Done. Show quoted text On 2014/03/06 16:28:49, Stephen Chenney wrote: > Recently we try to always put DOCTYPE at the top. Done.
	2 <script>

	3 if (window.testRunner) {

	4 testRunner.dumpAsText();

	5 testRunner.waitUntilDone();

	6 }

	7 window.onload = function() {

	8 if (window.testRunner)

	9 testRunner.notifyDone();

	10 }

	11 </script>

	12 <p>PASS</p>

	13 <svg xmlns="http://www.w3.org/2000/svg">

	14 <font>

	15 <font-face font-family="HappySad"></font-face>

	16 </font>

	17 <g style="-webkit-writing-mode: vertical-rl; " font-family="HappySad"><text><a ltGlyph>񫵳
	Stephen Chennney 2014/03/06 16:28:49 Does it still crash without the patch if you close Does it still crash without the patch if you close out all the tags etc? We also try to use well formed html/svg when it doesn't impact the test. And could you add a comment saying that the test passes if it does not crash. If it needs Asan or debug to crash, say that too. fs 2014/03/06 17:05:19 It does. Adjusted to be more well-formed. Show quoted text On 2014/03/06 16:28:49, Stephen Chenney wrote: > Does it still crash without the patch if you close out all the tags etc? We also > try to use well formed html/svg when it doesn't impact the test. It does. Adjusted to be more well-formed. Show quoted text > And could you add a comment saying that the test passes if it does not crash. If > it needs Asan or debug to crash, say that too. Added comment. (ASan or Debug not required.)
OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/svg/text/vertical-noncjk-non-existing-glyph-expected.txt » ('j') | no next file with comments »